1. 23 Dec, 2014 25 commits
    • Matt Stancliff's avatar
      Increase test size for migrating large values · c865809c
      Matt Stancliff authored
      Previously, the old test ran 5,000 loops and used about 500k.
      
      With quicklist, storing those same 5,000 loops takes up 24k, so the
      "large value check" failed!
      
      This increases the test to 20,000 loops which makes the object dump 96k.
      c865809c
    • Matt Stancliff's avatar
      Convert quicklist RDB to store ziplist nodes · 8919e153
      Matt Stancliff authored
      Turns out it's a huge improvement during save/reload/migrate/restore
      because, with compression enabled, we're compressing 4k or 8k
      chunks of data consisting of multiple elements in one ziplist
      instead of compressing series of smaller individual elements.
      8919e153
    • Matt Stancliff's avatar
      Convert RDB ziplist loading to sdsnative() · 73582497
      Matt Stancliff authored
      This saves us an unnecessary zmalloc, memcpy, and two frees.
      73582497
    • Matt Stancliff's avatar
      Add sdsnative() · 23a93d5c
      Matt Stancliff authored
      Use the existing memory space for an SDS to convert it to a regular
      character buffer so we don't need to allocate duplicate space just
      to extract a usable buffer for native operations.
      23a93d5c
    • Matt Stancliff's avatar
      Add adaptive quicklist fill factor · cb8032d6
      Matt Stancliff authored
      Fill factor now has two options:
        - negative (1-5) for size-based ziplist filling
        - positive for length-based ziplist filling with implicit size cap.
      
      Negative offsets define ziplist size limits of:
        -1: 4k
        -2: 8k
        -3: 16k
        -4: 32k
        -5: 64k
      
      Positive offsets now automatically limit their max size to 8k.  Any
      elements larger than 8k will be in individual nodes.
      
      Positive ziplist fill factors will keep adding elements
      to a ziplist until one of:
        - ziplist has FILL number of elements
          - or -
        - ziplist grows above our ziplist max size (currently 8k)
      
      When using positive fill factors, if you insert a large
      element (over 8k), that element will automatically allocate
      an individual quicklist node with one element and no other elements will be
      in the same ziplist inside that quicklist node.
      
      When using negative fill factors, elements up to the size
      limit can be added to one quicklist node.  If an element
      is added larger than the max ziplist size, that element
      will be allocated an individual ziplist in a new quicklist node.
      
      Tests also updated to start testing at fill factor -5.
      cb8032d6
    • Matt Stancliff's avatar
      redis-benchmark: Add RPUSH and RPOP tests · 2cf51b46
      Matt Stancliff authored
      2cf51b46
    • Matt Stancliff's avatar
      Free ziplist test lists during tests · 36f7ca08
      Matt Stancliff authored
      Freeing our test lists helps keep valgrind output clean
      36f7ca08
    • Matt Stancliff's avatar
      Add ziplistMerge() · b39bfb32
      Matt Stancliff authored
      This started out as #2158 by sunheehnus, but I kept rewriting it
      until I could understand things more easily and get a few more
      correctness guarantees out of the readability flow.
      
      The original commit created and returned a new ziplist with the contents of
      both input ziplists, but I prefer to grow one of the input ziplists
      and destroy the other one.
      
      So, instead of malloc+copy as in #2158, the merge now reallocs one of
      the existing ziplists and copies the other ziplist into the new space.
      
      Also added merge test cases to ziplistTest()
      b39bfb32
    • Matt Stancliff's avatar
      Add quicklist implementation · ff9e5b21
      Matt Stancliff authored
      This replaces individual ziplist vs. linkedlist representations
      for Redis list operations.
      
      Big thanks for all the reviews and feedback from everybody in
      https://github.com/antirez/redis/pull/2143
      ff9e5b21
    • Matt Stancliff's avatar
      Fix three simple clang analyzer warnings · d956d809
      Matt Stancliff authored
      d956d809
    • Matt Stancliff's avatar
      Cleanup ziplist valgrind warnings · 9b786b12
      Matt Stancliff authored
      Valgrind can't detect 'memset' initializes things, so let's
      statically initialize them to remove some unnecessary warnings.
      9b786b12
    • Matt Stancliff's avatar
      Fix ziplist test for pop() · 1dfcd75a
      Matt Stancliff authored
      The previous test wasn't returning the new ziplist, so the test
      was invalid.  Now the test works properly.
      
      These problems were simultaenously discovered in #2154 and that
      PR also had an additional fix we included here.
      1dfcd75a
    • Matt Stancliff's avatar
      Fix ziplistDeleteRange index parameter · 53b1ee34
      Matt Stancliff authored
      It's valid to delete from negative offsets, so we *don't*
      want unsigned arguments here.
      53b1ee34
    • Matt Stancliff's avatar
      Fix how zipEntry returns values · fae53dea
      Matt Stancliff authored
      zipEntry was returning a struct, but that caused some
      problems with tests under 32 bit builds.
      
      The tests run better if we operate on structs allocated in the
      caller without worrying about copying on return.
      fae53dea
    • Matt Stancliff's avatar
      Allow forcing non-jemalloc build · d01d4ddc
      Matt Stancliff authored
      d01d4ddc
    • Matt Stancliff's avatar
      Add simple ll2string() tests · 9b343678
      Matt Stancliff authored
      9b343678
    • Matt Stancliff's avatar
      Allow all code tests to run using Redis args · 8febcffd
      Matt Stancliff authored
      Previously, many files had individual main() functions for testing,
      but each required being compiled with their own testing flags.
      That gets difficult when you have 8 different flags you need
      to set just to run all tests (plus, some test files required
      other files to be compiled aaginst them, and it seems some didn't
      build at all without including the rest of Redis).
      
      Now all individual test main() funcions are renamed to a test
      function for the file itself and one global REDIS_TEST define enables
      testing across the entire codebase.
      
      Tests can now be run with:
        - `./redis-server test <test>`
      
        e.g. ./redis-server test ziplist
      
      If REDIS_TEST is not defined, then no tests get included and no
      tests are included in the final redis-server binary.
      8febcffd
    • Matt Stancliff's avatar
      Remove ziplist compiler warnings · 8380655e
      Matt Stancliff authored
      Only happen when compiled with the test define.
      8380655e
    • Matt Stancliff's avatar
      Add DEBUG JEMALLOC INFO · 27937c28
      Matt Stancliff authored
      Uses jemalloc function malloc_stats_print() to return
      stats about what jemalloc has allocated internally.
      27937c28
    • Matt Stancliff's avatar
      Add addReplyBulkSds() function · ad41a7c4
      Matt Stancliff authored
      Refactor a common pattern into one function so we don't
      end up with copy/paste programming.
      ad41a7c4
    • antirez's avatar
    • antirez's avatar
      INFO loading stats: three fixes. · 840435ad
      antirez authored
      1. Server unxtime may remain not updated while loading AOF, so ETA is
      not updated correctly.
      
      2. Number of processed byte was not initialized.
      
      3. Possible division by zero condition (likely cause of issue #1932).
      840435ad
    • Salvatore Sanfilippo's avatar
      Merge pull request #2227 from mattsta/fix/trib/assignment/master-replica · f7bc1fce
      Salvatore Sanfilippo authored
      Improve redis-trib replica assignment
      f7bc1fce
    • Salvatore Sanfilippo's avatar
      Merge pull request #2234 from mattsta/feature/sentinel-info-cache/age · 3a1ee895
      Salvatore Sanfilippo authored
      Add 'age' value to SENTINEL INFO-CACHE
      3a1ee895
    • Matt Stancliff's avatar
      Add 'age' value to SENTINEL INFO-CACHE · 32bba43a
      Matt Stancliff authored
      32bba43a
  2. 22 Dec, 2014 1 commit
  3. 21 Dec, 2014 2 commits
  4. 20 Dec, 2014 1 commit
  5. 19 Dec, 2014 1 commit
  6. 18 Dec, 2014 2 commits
  7. 17 Dec, 2014 8 commits