- 14 Dec, 2016 1 commit
-
-
Salvatore Sanfilippo authored
Reset the ttl for additional keys
-
- 13 Dec, 2016 5 commits
-
-
antirez authored
-
antirez authored
We need to use a dictionary type that frees the key, since we copy the keys in the dictionary we use to track expires created in the slave side.
-
antirez authored
-
antirez authored
-
antirez authored
BACKGROUND AND USE CASEj Redis slaves are normally write only, however the supprot a "writable" mode which is very handy when scaling reads on slaves, that actually need write operations in order to access data. For instance imagine having slaves replicating certain Sets keys from the master. When accessing the data on the slave, we want to peform intersections between such Sets values. However we don't want to intersect each time: to cache the intersection for some time often is a good idea. To do so, it is possible to setup a slave as a writable slave, and perform the intersection on the slave side, perhaps setting a TTL on the resulting key so that it will expire after some time. THE BUG Problem: in order to have a consistent replication, expiring of keys in Redis replication is up to the master, that synthesize DEL operations to send in the replication stream. However slaves logically expire keys by hiding them from read attemp...
-
- 12 Dec, 2016 2 commits
-
-
Salvatore Sanfilippo authored
Fix redis-cli rare crash.
-
Yossi Gottlieb authored
This happens if the server (mysteriously) returns an unexpected response to the COMMAND command.
-
- 08 Dec, 2016 1 commit
-
-
Jan-Erik Rediger authored
Before, if a previous key had a TTL set but the current one didn't, the TTL was reused and thus resulted in wrong expirations set. This behaviour was experienced, when `MigrateDefaultPipeline` in redis-trib was set to >1 Fixes #3655
-
- 06 Dec, 2016 2 commits
-
-
Salvatore Sanfilippo authored
Add '\n' to MEMORY DOCTOR command output message
-
wangshaonan authored
is 0 or empty is 1
-
- 05 Dec, 2016 5 commits
-
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
The test now uses more diverse radius sizes, especially sizes near or greater the whole earth surface are used, that are known to trigger edge cases. Moreover the PRNG seeding was probably resulting into the same sequence tested over and over again, now seeding unsing the current unix time in milliseconds. Related to #3631.
-
antirez authored
A bug was reported in the context in issue #3631. The root cause of the bug was that certain neighbor boxes were zeroed after the "inside the bounding box or not" check, simply because the bounding box computation function was wrong. A few debugging infos where enhanced and moved in other parts of the code. A check to avoid steps=0 was added, but is unrelated to this issue and I did not verified it was an actual bug in practice.
-
- 02 Dec, 2016 1 commit
-
-
antirez authored
No longer makes sense since writable slaves only do local writes now: writes are no longer passed to sub-slaves in the stream.
-
- 01 Dec, 2016 2 commits
-
-
Chris Lamb authored
-
Salvatore Sanfilippo authored
Fix typo in RedisModuleTypeMethods declaration.
-
- 30 Nov, 2016 4 commits
-
-
Yossi Gottlieb authored
-
Salvatore Sanfilippo authored
fix memory corruption on RM_FreeCallReply
-
antirez authored
-
Dvir Volk authored
-
- 29 Nov, 2016 5 commits
- 28 Nov, 2016 2 commits
-
-
antirez authored
This actually includes two changes: 1) No newlines to take the master-slave link up when the upstream master is down. Doing this is dangerous because the sub-slave often is received replication protocol for an half-command, so can't receive newlines without desyncing the replication link, even with the code in order to cancel out the bytes that PSYNC2 was using. Moreover this is probably also not needed/sane, because anyway the slave can keep serving requests, and because if it's configured to don't serve stale data, it's a good idea, actually, to break the link. 2) When a +CONTINUE with a different ID is received, we now break connection with the sub-slaves: they need to be notified as well. This was part of the original specification but for some reason it was not implemented in the code, and was alter found as a PSYNC2 bug in the integration testing.
-
antirez authored
This is the PSYNC2 test that helped find issues in the code, and that still can show a protocol desync from time to time. Work is in progress in order to find the issue. For now the test is not enabled in "make test" and must be run manually.
-
- 25 Nov, 2016 1 commit
-
-
antirez authored
-
- 24 Nov, 2016 2 commits
- 23 Nov, 2016 1 commit
-
-
antirez authored
1. Master replication offset was cleared after switching configuration to some other slave, since it was assumed you can't PSYNC after a switch. Note the case anymore and when we successfully PSYNC we need to have our offset untouched. 2. Secondary replication ID was not reset to "000..." pattern at startup. 3. Master in error state replying -LOADING or other transient errors forced the slave to discard the cached master and full resync. This is now fixed. 4. Better logging of what's happening on failed PSYNCs.
-
- 18 Nov, 2016 3 commits
-
-
antirez authored
-
antirez authored
-
Salvatore Sanfilippo authored
fix a possible bug for 'replconf getack'
-
- 17 Nov, 2016 1 commit
-
-
antirez authored
-
- 16 Nov, 2016 2 commits