- 19 Dec, 2014 1 commit
-
-
antirez authored
Fixes issue #2225.
-
- 17 Dec, 2014 1 commit
-
-
Rhommel Lamas authored
-
- 16 Dec, 2014 1 commit
-
-
antirez authored
-
- 13 Dec, 2014 2 commits
-
-
antirez authored
Otherwise there are security risks, especially when providing Redis as a service, the user may "sniff" for admin commands renamed to an unguessable string via rename-command in redis.conf.
-
antirez authored
The old list did not made much sense... and the flag is currently not used at all, so no side effects.
-
- 12 Dec, 2014 1 commit
-
-
Rhommel Lamas authored
-
- 11 Dec, 2014 3 commits
-
-
antirez authored
Related to #2094.
-
Matt Stancliff authored
People mostly use SORT against lists, but our prior behavior was pretending lists were an unordered bag requiring a forced-sort when no sort was requested. We can just use the native list ordering to ensure consistency across replicaion and scripting calls. Closes #2079 Closes #545 (again)
-
zhanghailei authored
-
- 09 Dec, 2014 12 commits
-
-
Sun He authored
-
Deepak Verma authored
-
azure provisioned user authored
-
Sun He authored
-
Sun He authored
-
Sun He authored
-
antirez authored
-
Jan-Erik Rediger authored
-
-
Sun He authored
-
Sun He authored
-
Jan-Erik Rediger authored
This allows shell pipes to correctly end redis-cli. Ref #2066
-
- 04 Dec, 2014 2 commits
- 03 Dec, 2014 4 commits
-
-
antirez authored
Track bandwidth used by clients and replication (but diskless replication is not tracked since the actual transfer happens in the child process). This includes a refactoring that makes tracking new instantaneous metrics simpler.
-
antirez authored
Closes issue #1935.
-
antirez authored
-
antirez authored
Ref: issue #2175
-
- 02 Dec, 2014 2 commits
-
-
antirez authored
-
antirez authored
PFCOUNT is technically speaking a write command, since the cached value of the HLL is exposed in the data structure (design error, mea culpa), and can be modified by PFCOUNT. However if we flag PFCOUNT as "w", read only slaves can't execute the command, which is a problem since there are environments where slaves are used to scale PFCOUNT reads. Nor it is possible to just prevent PFCOUNT to modify the data structure in slaves, since without the cache we lose too much efficiency. So while this commit allows slaves to create a temporary inconsistency (the strings representing the HLLs in the master and slave can be different in certain moments) it is actually harmless. In the long run this should be probably fixed by turning the HLL into a more opaque representation, for example by storing the cached value in the part of the string which is not exposed (this should be possible with SDS strings).
-
- 28 Nov, 2014 2 commits
-
-
antirez authored
10000 completes in a too short time and may easily provide unreliable figures because of tiny duration.
-
Matthias Petschick authored
-
- 25 Nov, 2014 2 commits
-
-
antirez authored
-
antirez authored
zmalloc(0) cauesd to actually trigger a non-zero allocation since with standard libc malloc we have our own zmalloc header for memory tracking, but at the same time the returned pointer is at the end of the block and not in the middle. This triggers a false positive when testing with valgrind. When the inline protocol args count is 0, we now avoid reallocating c->argv, preventing the issue to happen.
-
- 14 Nov, 2014 2 commits
-
-
antirez authored
-
Matt Stancliff authored
A few people have written custom C commands because bit manipulation isn't exposed through Lua. Let's give them Mike Pall's bitop. This adds bitop 1.0.2 (2012-05-08) from http://bitop.luajit.org/ bitop is imported as "bit" into the global namespace. New Lua commands: bit.tobit, bit.tohex, bit.bnot, bit.band, bit.bor, bit.bxor, bit.lshift, bit.rshift, bit.arshift, bit.rol, bit.ror, bit.bswap Verification of working (the asserts would abort on error, so (nil) is correct): 127.0.0.1:6379> eval "assert(bit.tobit(1) == 1); assert(bit.band(1) == 1); assert(bit.bxor(1,2) == 3); assert(bit.bor(1,2,4,8,16,32,64,128) == 255)" 0 (nil) 127.0.0.1:6379> eval 'assert(0x7fffffff == 2147483647, "broken hex literals"); assert(0xffffffff == -1 or 0xffffffff == 2^32-1, "broken hex literals"); assert(tostring(-1) == "-1", "broken tostring()"); assert(tostring(0xffffffff) == "-1" or tostring(0xffffffff) == "4294967295", "broken tostring()")' 0 (nil) Tests also integrated into the scripting tests and can be run with: ./runtest --single unit/scripting Tests are excerpted from `bittest.lua` included in the bitop distribution.
-
- 12 Nov, 2014 3 commits
- 11 Nov, 2014 2 commits
-
-
antirez authored
RDB EOF detection was relying on the final part of the RDB transfer to be a magic 40 bytes EOF marker. However as the slave is put online immediately, and because of sockets timeouts, the replication stream is actually contiguous with the RDB file. This means that to detect the EOF correctly we should either: 1) Scan all the stream searching for the mark. Sucks CPU-wise. 2) Start to send the replication stream only after an acknowledge. 3) Implement a proper chunked encoding. For now solution "2" was picked, so the master does not start to send ASAP the stream of commands in the case of diskless replication. We wait for the first REPLCONF ACK command from the slave, that certifies us that the slave correctly loaded the RDB file and is ready to get more data.
-
antirez authored
-