1. 20 May, 2014 19 commits
    • antirez's avatar
      Remove trailing spaces from sentinel.c. · d0c84acc
      antirez authored
      d0c84acc
    • michael-grunder's avatar
      Fix LUA_OBJCACHE segfault. · 6f493951
      michael-grunder authored
      When scanning the argument list inside of a redis.call() invocation
      for pre-cached values, there was no check being done that the
      argument we were on was in fact within the bounds of the cache size.
      
      So if a redis.call() command was ever executed with more than 32
      arguments (current cache size #define setting) redis-server could
      segfault.
      6f493951
    • antirez's avatar
    • antirez's avatar
      Cluster test: failure detection initial tests. · a7fd2eb5
      antirez authored
      a7fd2eb5
    • antirez's avatar
      a82c000b
    • antirez's avatar
      Cluster: use clusterSetNodeAsMaster() during slave failover. · 8c6e8680
      antirez authored
      clusterHandleSlaveFailover() was reimplementing what
      clusterSetNodeAsMaster() without any good reason.
      8c6e8680
    • antirez's avatar
      Cluster: clear todo_before_sleep flags when executing actions. · 41a72416
      antirez authored
      Thanks to this change, when there is some code like:
      
          clusterDoBeforeSleep(CLUSTER_TODO_UPDATE_STATE|...);
          ... and later before returning to the event loop ...
          clusterUpdateState();
      
      The clusterUpdateState() function will clar the flag and will not be
      repeated in the clusterBeforeSleep() function. This especially important
      for config save/fsync flags which are slow to execute and not a good
      idea to repeat without a good reason.
      
      This is implemented for all the CLUSTER_TODO flags.
      41a72416
    • antirez's avatar
      Fixed typo in CLUSTER RESET implementation. · 5685d15a
      antirez authored
      5685d15a
    • antirez's avatar
      CLUSTER RESET implemented. · 5efa5501
      antirez authored
      The new command is able to reset a cluster node so that it starts again
      as a fresh node. By default the command performs a soft reset (the same
      as calling it as CLUSTER RESET SOFT), and the following steps are
      performed:
      
      1) All slots are set as unassigned.
      2) The list of known nodes is flushed.
      3) Node is set as master if it is a slave.
      
      When an hard reset is performed with CLUSTER RESET HARD the following
      additional operations are performed:
      
      4) A new Node ID is created at random.
      5) Epochs are set to 0.
      
      CLUSTER RESET is useful both when the sysadmin wants to reconfigure a
      node with a different role (for example turning a slave into a master)
      and for testing purposes.
      
      It also may play a role in automatically provisioned Redis Clusters,
      since it allows to reset a node back to the initial state in order to be
      reconfigured.
      5efa5501
    • antirez's avatar
      Remove trailing spaces from cluster.c file. · 687f84a3
      antirez authored
      687f84a3
    • antirez's avatar
      d2790240
    • antirez's avatar
      be159490
    • antirez's avatar
      Cluster: better handling of stolen slots. · b8a71e5a
      antirez authored
      The previous code handling a lost slot (by another master with an higher
      configuration for the slot) was defensive, considering it an error and
      putting the cluster in an odd state requiring redis-cli fix.
      
      This was changed, because actually this only happens either in a
      legitimate way, with failovers, or when the admin messed with the config
      in order to reconfigure the cluster. So the new code instead will try to
      make sure that the keys stored match the new slots map, by removing all
      the keys in the slots we lost ownership from.
      
      The function that deletes the keys from the lost slots is called only
      if the node does not lose all its slots (resulting in a reconfiguration
      as a slave of the node that got ownership). This is an optimization
      since the replication code will anyway flush all the instance data in
      a faster way.
      b8a71e5a
    • antirez's avatar
      f727000f
    • antirez's avatar
      cluster.tcl: saner error handling. · 4db4a5d5
      antirez authored
      Better handling of connection errors in order to update the table and
      recovery, populate the startup nodes table after fetching the list of
      nodes.
      
      More work to do about it, it is still not as reliable as
      redis-rb-cluster implementation which is the minimal reference
      implementation for Redis Cluster clients.
      4db4a5d5
    • antirez's avatar
    • antirez's avatar
      e10ee072
    • antirez's avatar
      Cluster: forced failover implemented. · e84dcabf
      antirez authored
      Using CLUSTER FAILOVER FORCE it is now possible to failover a master in
      a forced way, which means:
      
      1) No check to understand if the master is up is performed.
      2) No data age of the slave is checked. Evan a slave with very old data
         can manually failover a master in this way.
      3) No chat with the master is attempted to reach its replication offset:
         the master can just be down.
      e84dcabf
    • antirez's avatar
      Cluster: bypass data_age check for manual failovers. · b5cdd42b
      antirez authored
      Automatic failovers only happen in Redis Cluster if the slave trying to
      be elected was disconnected from its master for no more than 10 times
      the node-timeout value. However there should be no such a check for
      manual failovers, since these are initiated by the sysadmin that, in
      theory, knows what she is doing when a slave is selected to be promoted.
      b5cdd42b
  2. 19 May, 2014 2 commits
  3. 12 May, 2014 10 commits
  4. 09 May, 2014 3 commits
  5. 08 May, 2014 3 commits
    • antirez's avatar
      Sentinel: log when a failover will be attempted again. · 6eadeb72
      antirez authored
      When a Sentinel performs a failover (successful or not), or when a
      Sentinel votes for a different Sentinel trying to start a failover, it
      sets a min delay before it will try to get elected for a failover.
      
      While not strictly needed, because if multiple Sentinels will try
      to failover the same master at the same time, only one configuration
      will eventually win, this serialization is practically very useful.
      Normal failovers are cleaner: one Sentinel starts to failover, the
      others update their config when the Sentinel performing the failover
      is able to get the selected slave to move from the role of slave to the
      one of master.
      
      However currently this timeout was implicit, so users could see
      Sentinels not reacting, after a failed failover, for some time, without
      giving any feedback in the logs to the poor sysadmin waiting for clues.
      
      This commit makes Sentinels more verbose about the delay: when a master
      is down and a failover attempt is not performed because the delay has
      still not elaped, something like that will be logged:
      
          Next failover delay: I will not start a failover
          before Thu May  8 16:48:59 2014
      6eadeb72
    • antirez's avatar
      Sentinel: generate +config-update-from event when a new config is received. · c738f0f4
      antirez authored
      This event makes clear, before the switch-master event is generated,
      that a Sentinel received a configuration update from another Sentinel.
      c738f0f4
    • antirez's avatar
      REDIS_ENCODING_EMBSTR_SIZE_LIMIT set to 39. · d8ffd2b2
      antirez authored
      The new value is the limit for the robj + SDS header + string +
      null-term to stay inside the 64 bytes Jemalloc arena in 64 bits
      systems.
      d8ffd2b2
  6. 07 May, 2014 3 commits
    • antirez's avatar
      Scripting test: check that Lua can call commands rewirting argv. · 35b94422
      antirez authored
      SPOP, tested in the new test, is among the commands rewritng the
      client->argv argument vector (it gets rewritten as SREM) for command
      replication purposes.
      
      Because of recent optimizations to client->argv caching in the context
      of the Lua internal Redis client, it is important to test for SPOP to be
      callable from Lua without bad effects to the other commands.
      35b94422
    • antirez's avatar
      Test: handle new osx 'leaks' error. · 1255460c
      antirez authored
      Sometimes the process is still there but no longer in a state that can
      be checked (after being killed). This used to happen after a call to
      SHUTDOWN NOSAVE in the scripting unit, causing a false positive.
      1255460c
    • antirez's avatar
      Scripting: objects caching for Lua c->argv creation. · baf93017
      antirez authored
      Reusing small objects when possible is a major speedup under certain
      conditions, since it is able to avoid the malloc/free pattern that
      otherwise is performed for every argument in the client command vector.
      baf93017