1. 03 Dec, 2012 2 commits
    • antirez's avatar
      Redis 2.6.7 · d9301f05
      antirez authored
      d9301f05
    • antirez's avatar
      Memory leak fixed: release client's bpop->keys dictionary. · 984f6edf
      antirez authored
      Refactoring performed after issue #801 resolution (see commit
      2f87cf8b) introduced a memory leak that
      is fixed by this commit.
      
      I simply forgot to free the new allocated dictionary in the client
      structure trusting the output of "make test" on OSX.
      
      However due to changes in the "leaks" utility the test was no longer
      testing memory leaks. This problem was also fixed.
      
      Fortunately the CI test running at ci.redis.io spotted the bug in the
      valgrind run.
      
      The leak never ended into a stable release.
      984f6edf
  2. 02 Dec, 2012 1 commit
    • antirez's avatar
      Blocking POP: use a dictionary to store keys clinet side. · 54b08c86
      antirez authored
      To store the keys we block for during a blocking pop operation, in the
      case the client is blocked for more data to arrive, we used a simple
      linear array of redis objects, in the blockingState structure:
      
          robj **keys;
          int count;
      
      However in order to fix issue #801 we also use a dictionary in order to
      avoid to end in the blocked clients queue for the same key multiple
      times with the same client.
      
      The dictionary was only temporary, just to avoid duplicates, but since
      we create / destroy it there is no point in doing this duplicated work,
      so this commit simply use a dictionary as the main structure to store
      the keys we are blocked for. So instead of the previous fields we now
      just have:
      
          dict *keys;
      
      This simplifies the code and reduces the work done by the server during
      a blocking POP operation.
      54b08c86
  3. 01 Dec, 2012 1 commit
    • antirez's avatar
      Client should not block multiple times on the same key. · cac49a90
      antirez authored
      Sending a command like:
      
      BLPOP foo foo foo foo 0
      
      Resulted into a crash before this commit since the client ended being
      inserted in the waiting list for this key multiple times.
      This resulted into the function handleClientsBlockedOnLists() to fail
      because we have code like that:
      
          if (de) {
              list *clients = dictGetVal(de);
              int numclients = listLength(clients);
      
              while(numclients--) {
                  listNode *clientnode = listFirst(clients);
      
                  /* server clients here... */
              }
          }
      
      The code to serve clients used to remove the served client from the
      waiting list, so if a client is blocking multiple times, eventually the
      call to listFirst() will return NULL or worse will access random memory
      since the list may no longer exist as it is removed by the function
      unblockClientWaitingData() if there are no more clients waiting for this
      list.
      
      To avoid making the rest of the implementation more complex, this commit
      modifies blockForKeys() so that a client will be put just a single time
      into the waiting list for a given key.
      
      Since it is Saturday, I hope this fixes issue #801.
      cac49a90
  4. 28 Nov, 2012 1 commit
  5. 22 Nov, 2012 4 commits
    • antirez's avatar
      Redis 2.6.5 · 3ccfb5a4
      antirez authored
      3ccfb5a4
    • antirez's avatar
      EVALSHA is now case insensitive. · 9120275d
      antirez authored
      EVALSHA used to crash if the SHA1 was not lowercase (Issue #783).
      Fixed using a case insensitive dictionary type for the sha -> script
      map used for replication of scripts.
      9120275d
    • antirez's avatar
      Fix integer overflow in zunionInterGenericCommand(). · de00a5a0
      antirez authored
      This fixes issue #761.
      de00a5a0
    • antirez's avatar
      Safer handling of MULTI/EXEC on errors. · 41f0f927
      antirez authored
      After the transcation starts with a MULIT, the previous behavior was to
      return an error on problems such as maxmemory limit reached. But still
      to execute the transaction with the subset of queued commands on EXEC.
      
      While it is true that the client was able to check for errors
      distinguish QUEUED by an error reply, MULTI/EXEC in most client
      implementations uses pipelining for speed, so all the commands and EXEC
      are sent without caring about replies.
      
      With this change:
      
      1) EXEC fails if at least one command was not queued because of an
      error. The EXECABORT error is used.
      2) A generic error is always reported on EXEC.
      3) The client DISCARDs the MULTI state after a failed EXEC, otherwise
      pipelining multiple transactions would be basically impossible:
      After a failed EXEC the next transaction would be simply queued as
      the tail of the previous transaction.
      41f0f927
  6. 20 Nov, 2012 2 commits
    • antirez's avatar
      Children creating AOF or RDB files now report memory used by COW. · 5ab4151d
      antirez authored
      Finally Redis is able to report the amount of memory used by
      copy-on-write while saving an RDB or writing an AOF file in background.
      
      Note that this information is currently only logged (at NOTICE level)
      and not shown in INFO because this is less trivial (but surely doable
      with some minor form of interprocess communication).
      
      The reason we can't capture this information on the parent before we
      call wait3() is that the Linux kernel will release the child memory
      ASAP, and only retain the minimal state for the process that is useful
      to report the child termination to the parent.
      
      The COW size is obtained by summing all the Private_Dirty fields found
      in the "smap" file inside the proc filesystem for the process.
      
      All this is Linux specific and is not available on other systems.
      5ab4151d
    • antirez's avatar
      zmalloc_get_private_dirty() function added (Linux only). · e95ca663
      antirez authored
      For non Linux systmes it just returns 0.
      
      This function is useful to estimate copy-on-write because of childs
      saving stuff on disk.
      e95ca663
  7. 14 Nov, 2012 1 commit
  8. 12 Nov, 2012 3 commits
  9. 08 Nov, 2012 2 commits
  10. 06 Nov, 2012 1 commit
  11. 02 Nov, 2012 1 commit
  12. 01 Nov, 2012 3 commits
  13. 31 Oct, 2012 1 commit
    • antirez's avatar
      Invert two sides of if expression in SET to avoid a lookup. · 4d9bd535
      antirez authored
      Because of the short circuit behavior of && inverting the two sides of
      the if expression avoids an hash table lookup if the non-EX variant of
      SET is called.
      
      Thanks to Weibin Yao (@yaoweibin on github) for spotting this.
      4d9bd535
  14. 30 Oct, 2012 2 commits
  15. 26 Oct, 2012 3 commits
  16. 25 Oct, 2012 2 commits
  17. 24 Oct, 2012 1 commit
  18. 22 Oct, 2012 6 commits
    • antirez's avatar
      Redis 2.6.0 · 5eec376c
      antirez authored
      5eec376c
    • antirez's avatar
      A filed called slave_read_only added in INFO output. · 99d7dbe6
      antirez authored
      This was an important information missing from the INFO output in the
      replication section.
      
      It obviously reflects if the slave is read only or not.
      99d7dbe6
    • Greg Hurrell's avatar
      Fix (cosmetic) typos in dict.h · a61705dd
      Greg Hurrell authored
      a61705dd
    • Schuster's avatar
      redis-check-dump now understands dumps produced by Redis 2.6 · 16144589
      Schuster authored
      (Commit message from @antirez as it was missign in the original commits,
      also the patch was modified a bit to still work with 2.4 dumps and to
      avoid if expressions that are always true due to checked types range)
      
      This commit changes redis-check-dump to account for new encodings and
      for the new MSTIME expire format. It also refactors the test for valid
      type into a function.
      
      The code is still compatible with Redis 2.4 generated dumps.
      
      This fixes issue #709.
      16144589
    • antirez's avatar
      Default memory limit for 32bit instanced moved from 3.5 GB to 3 GB. · a25b25f4
      antirez authored
      In some system, notably osx, the 3.5 GB limit was too far and not able
      to prevent a crash for out of memory. The 3 GB limit works better and it
      is still a lot of memory within a 4 GB theorical limit so it's not going
      to bore anyone :-)
      
      This fixes issue #711
      a25b25f4
    • antirez's avatar
      Differentiate SCRIPT KILL error replies. · ab551808
      antirez authored
      When calling SCRIPT KILL currently you can get two errors:
      
      * No script in timeout (busy) state.
      * The script already performed a write.
      
      It is useful to be able to distinguish the two errors, but right now both
      start with "ERR" prefix, so string matching (that is fragile) must be used.
      
      This commit introduces two different prefixes.
      
      -NOTBUSY and -UNKILLABLE respectively to reply with an error when no
      script is busy at the moment, and when the script already executed a
      write operation and can not be killed.
      ab551808
  19. 18 Oct, 2012 1 commit
    • NanXiao's avatar
      Update src/redis-benchmark.c · a03c3270
      NanXiao authored
      The code of current implementation:
      
      if (c->pending == 0) clientDone(c);
      In clientDone function, the c's memory has been freed, then the loop will continue: while(c->pending). The memory of c has been freed now, so c->pending is invalid (c is an invalid pointer now), and this will cause memory dump in some platforams(eg: Solaris).
      
      So I think the code should be modified as:
      if (c->pending == 0)
      {
      clientDone(c);
      break;
      }
      and this will not lead to while(c->pending).
      a03c3270
  20. 16 Oct, 2012 1 commit
    • antirez's avatar
      Fix MULTI / EXEC rendering in MONITOR output. · 21645232
      antirez authored
      Before of this commit it used to be like this:
      
      MULTI
      EXEC
      ... actual commands of the transaction ...
      
      Because after all that is the natural order of things. Transaction
      commands are queued and executed *only after* EXEC is called.
      
      However this makes debugging with MONITOR a mess, so the code was
      modified to provide a coherent output.
      
      What happens is that MULTI is rendered in the MONITOR output as far as
      possible, instead EXEC is propagated only after the transaction is
      executed, or even in the case it fails because of WATCH, so in this case
      you'll simply see:
      
      MULTI
      EXEC
      
      An empty transaction.
      21645232
  21. 11 Oct, 2012 1 commit