1. 21 Jun, 2014 12 commits
    • antirez's avatar
      Client types generalized. · d97d1a64
      antirez authored
      Because of output buffer limits Redis internals had this idea of type of
      clients: normal, pubsub, slave. It is possible to set different output
      buffer limits for the three kinds of clients.
      
      However all the macros and API were named after output buffer limit
      classes, while the idea of a client type is a generic one that can be
      reused.
      
      This commit does two things:
      
      1) Rename the API and defines with more general names.
      2) Change the class of clients executing the MONITOR command from "slave"
         to "normal".
      
      "2" is a good idea because you want to have very special settings for
      slaves, that are not a good idea for MONITOR clients that are instead
      normal clients even if they are conceptually slave-alike (since it is a
      push protocol).
      
      The backward-compatibility breakage resulting from "2" is considered to
      be minimal to care, since MONITOR is a debugging command, and because
      anyway this change is not going to break the format or the behavior, but
      just when a connection is closed on big output buffer issues.
      d97d1a64
    • antirez's avatar
      Fix semantics of Lua calls to SELECT. · 2b57d96e
      antirez authored
      Lua scripts are executed in the context of the currently selected
      database (as selected by the caller of the script).
      
      However Lua scripts are also free to use the SELECT command in order to
      affect other DBs. When SELECT is called frm Lua, the old behavior, before
      this commit, was to automatically set the Lua caller selected DB to the
      last DB selected by Lua. See for example the following sequence of
      commands:
      
          SELECT 0
          SET x 10
          EVAL "redis.call('select','1')" 0
          SET x 20
      
      Before this commit after the execution of this sequence of commands,
      we'll have x=10 in DB 0, and x=20 in DB 1.
      
      Because of the problem above, there was a bug affecting replication of
      Lua scripts, because of the actual implementation of replication. It was
      possible to fix the implementation of Lua scripts in order to fix the
      issue, but looking closely, the bug is the consequence of the behavior
      of Lua ability to set the caller's DB.
      
      Under the old semantics, a script selecting a different DB, has no simple
      ways to restore the state and select back the previously selected DB.
      Moreover the script auhtor must remember that the restore is needed,
      otherwise the new commands executed by the caller, will be executed in
      the context of a different DB.
      
      So this commit fixes both the replication issue, and this hard-to-use
      semantics, by removing the ability of Lua, after the script execution,
      to force the caller to switch to the DB selected by the Lua script.
      
      The new behavior of the previous sequence of commadns is to just set
      X=20 in DB 0. However Lua scripts are still capable of writing / reading
      from different DBs if needed.
      
      WARNING: This is a semantical change that will break programs that are
      conceived to select the client selected DB via Lua scripts.
      
      This fixes issue #1811.
      2b57d96e
    • antirez's avatar
      Scripting: Fix for a #1118 regression simplified. · 0f4b925d
      antirez authored
      It is more straightforward to just test for a numerical type avoiding
      Lua's automatic conversion. The code is technically more correct now,
      however Lua should automatically convert to number only if the original
      type is a string that "looks like a number", and not from other types,
      so practically speaking the fix is identical AFAIK.
      0f4b925d
    • Matt Stancliff's avatar
      Scripting: Fix regression from #1118 · 9ca83c82
      Matt Stancliff authored
      The new check-for-number behavior of Lua arguments broke
      users who use large strings of just integers.
      
      The Lua number check would convert the string to a number, but
      that breaks user data because
      Lua numbers have limited precision compared to an arbitrarily
      precise number wrapped in a string.
      
      Regression fixed and new test added.
      
      Fixes #1118 again.
      9ca83c82
    • antirez's avatar
    • antirez's avatar
    • antirez's avatar
      Cluster: log granted failover authorizations. · 78a687ec
      antirez authored
      78a687ec
    • antirez's avatar
      Cluster: log configEpoch updates to myself. · 61910a67
      antirez authored
      61910a67
    • antirez's avatar
      111a5556
    • antirez's avatar
      5cdefb7c
    • antirez's avatar
      ROLE output improved for slaves. · 2213f283
      antirez authored
      Info about the replication state with the master added.
      2213f283
    • antirez's avatar
      ROLE command added. · 9b460e80
      antirez authored
      The new ROLE command is designed in order to provide a client with
      informations about the replication in a fast and easy to use way
      compared to the INFO command where the same information is also
      available.
      9b460e80
  2. 09 Jun, 2014 4 commits
    • antirez's avatar
      Redis 2.9.55 (Redis 3.0.0 beta-6). · ea5335fb
      antirez authored
      ea5335fb
    • Matt Stancliff's avatar
      Fix lack of strtold under Cygwin · 726d343a
      Matt Stancliff authored
      Renaming strtold to strtod then casting
      the result is the standard way of dealing with
      no strtold in Cygwin.
      726d343a
    • Matt Stancliff's avatar
      Fix lack of SA_ONSTACK under Cygwin · 28fef5c5
      Matt Stancliff authored
      Fixes #232
      28fef5c5
    • Matt Stancliff's avatar
      Fix blocking operations from missing new lists · 7fc1fc8c
      Matt Stancliff authored
      Behrad Zari discovered [1] and Josiah reported [2]: if you block
      and wait for a list to exist, but the list creates from
      a non-push command, the blocked client never gets notified.
      
      This commit adds notification of blocked clients into
      the DB layer and away from individual commands.
      
      Lists can be created by [LR]PUSH, SORT..STORE, RENAME, MOVE,
      and RESTORE.  Previously, blocked client notifications were
      only triggered by [LR]PUSH.  Your client would never get
      notified if a list were created by SORT..STORE or RENAME or
      a RESTORE, etc.
      
      Blocked client notification now happens in one unified place:
        - dbAdd() triggers notification when adding a list to the DB
      
      Two new tests are added that fail prior to this commit.
      
      All test pass.
      
      Fixes #1668
      
      [1]: https://groups.google.com/forum/#!topic/redis-db/k4oWfMkN1NU
      [2]: #1668
      7fc1fc8c
  3. 07 Jun, 2014 2 commits
    • antirez's avatar
      Cluster: check that configEpoch never goes back. · 8b059f06
      antirez authored
      Since there are ways to alter the configEpoch outside of the failover
      procedure (for exampel CLUSTER SET-CONFIG-EPOCH and via the configEpoch
      collision resolution algorithm), make always sure, before replacing our
      configEpoch with a new one, that it is greater than the current one.
      8b059f06
    • antirez's avatar
      Cluster: SET-CONFIG-EPOCH should update currentEpoch. · 67029323
      antirez authored
      SET-CONFIG-EPOCH, used by redis-trib at cluster creation time, failed to
      update the currentEpoch, making it possible after a failover for a
      server to set its configEpoch to a value smaller than the current one
      (since configEpochs are obtained using currentEpoch).
      
      The bug totally break the Redis Cluster algorithms and protocols
      allowing for permanent split brain conditions about the slots
      configuration as shown in issue #1799.
      67029323
  4. 06 Jun, 2014 3 commits
  5. 05 Jun, 2014 1 commit
  6. 04 Jun, 2014 2 commits
    • antirez's avatar
      Fixed dbuf variable scope in luaRedisGenericCommand(). · 751c8698
      antirez authored
      I'm not sure if while the visibility is the inner block, the fact we
      point to 'dbuf' is a problem or not, probably the stack var isx
      guaranteed to live until the function returns. However obvious code is
      better anyway.
      751c8698
    • antirez's avatar
      Scripting: better Lua number -> string conversion in luaRedisGenericCommand(). · c3967f42
      antirez authored
      The lua_to*string() family of functions use a non optimal format
      specifier when converting integers to strings. This has both the problem
      of the number being converted in exponential notation, which we don't
      use as a Redis return value when floating point numbers are involed,
      and, moreover, there is a loss of precision since the default format
      specifier is not able to represent numbers that must be represented
      exactly in the IEEE 754 number mantissa.
      
      The new code handles it as a special case using a saner conversion.
      
      This fixes issue #1118.
      c3967f42
  7. 28 May, 2014 1 commit
  8. 26 May, 2014 3 commits
  9. 23 May, 2014 7 commits
  10. 20 May, 2014 5 commits
    • antirez's avatar
      Remove trailing spaces from scripting.c · d357e3ee
      antirez authored
      d357e3ee
    • antirez's avatar
      Remove trailing spaces from sentinel.c. · d0c84acc
      antirez authored
      d0c84acc
    • michael-grunder's avatar
      Fix LUA_OBJCACHE segfault. · 6f493951
      michael-grunder authored
      When scanning the argument list inside of a redis.call() invocation
      for pre-cached values, there was no check being done that the
      argument we were on was in fact within the bounds of the cache size.
      
      So if a redis.call() command was ever executed with more than 32
      arguments (current cache size #define setting) redis-server could
      segfault.
      6f493951
    • antirez's avatar
      Cluster: use clusterSetNodeAsMaster() during slave failover. · 8c6e8680
      antirez authored
      clusterHandleSlaveFailover() was reimplementing what
      clusterSetNodeAsMaster() without any good reason.
      8c6e8680
    • antirez's avatar
      Cluster: clear todo_before_sleep flags when executing actions. · 41a72416
      antirez authored
      Thanks to this change, when there is some code like:
      
          clusterDoBeforeSleep(CLUSTER_TODO_UPDATE_STATE|...);
          ... and later before returning to the event loop ...
          clusterUpdateState();
      
      The clusterUpdateState() function will clar the flag and will not be
      repeated in the clusterBeforeSleep() function. This especially important
      for config save/fsync flags which are slow to execute and not a good
      idea to repeat without a good reason.
      
      This is implemented for all the CLUSTER_TODO flags.
      41a72416