- 29 Apr, 2015 1 commit
-
-
antirez authored
This commit allows to avoid two mstime() calls inside the call() function, when the following conditions are true: 1. slowlog is disabled. 2. latency monitoring is disabled. 3. command time acconuting is disabled. Note that '3' was not configurable, this patch just disable it without really allowing the user to turn it on, since this is currently an experiment. If the commit will be merged into unstable, proper support to configure this parameter will be added. Related to issue #2552.
-
- 23 Dec, 2014 1 commit
-
-
antirez authored
1. Server unxtime may remain not updated while loading AOF, so ETA is not updated correctly. 2. Number of processed byte was not initialized. 3. Possible division by zero condition (likely cause of issue #1932).
-
- 19 Dec, 2014 1 commit
-
-
antirez authored
Fixes issue #2225.
-
- 13 Dec, 2014 2 commits
-
-
antirez authored
Otherwise there are security risks, especially when providing Redis as a service, the user may "sniff" for admin commands renamed to an unguessable string via rename-command in redis.conf.
-
antirez authored
The old list did not made much sense... and the flag is currently not used at all, so no side effects.
-
- 04 Dec, 2014 1 commit
-
-
antirez authored
-
- 03 Dec, 2014 2 commits
- 02 Dec, 2014 1 commit
-
-
antirez authored
PFCOUNT is technically speaking a write command, since the cached value of the HLL is exposed in the data structure (design error, mea culpa), and can be modified by PFCOUNT. However if we flag PFCOUNT as "w", read only slaves can't execute the command, which is a problem since there are environments where slaves are used to scale PFCOUNT reads. Nor it is possible to just prevent PFCOUNT to modify the data structure in slaves, since without the cache we lose too much efficiency. So while this commit allows slaves to create a temporary inconsistency (the strings representing the HLLs in the master and slave can be different in certain moments) it is actually harmless. In the long run this should be probably fixed by turning the HLL into a more opaque representation, for example by storing the cached value in the part of the string which is not exposed (this should be possible with SDS strings).
-
- 12 Nov, 2014 1 commit
-
-
antirez authored
-
- 29 Oct, 2014 5 commits
-
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
We need to remember what is the saving strategy of the current RDB child process, since the configuration may be modified at runtime via CONFIG SET and still we'll need to understand, when the child exists, what to do and for what goal the process was initiated: to create an RDB file on disk or to write stuff directly to slave's sockets.
-
- 06 Oct, 2014 2 commits
-
-
T.J. Schuck authored
Closes #1938
-
Juarez Bochi authored
Closes #1682
-
- 16 Sep, 2014 1 commit
-
-
antirez authored
This is a general fix (check that dirty delta is positive) but actually should have as the only effect fixing the SAVE propagation to AOF and slaves.
-
- 08 Sep, 2014 1 commit
-
-
antirez authored
-
- 27 Aug, 2014 9 commits
-
-
Matt Stancliff authored
We don't want scripts doing CLIENT SETNAME or CLIENT KILL or CLIENT LIST or CLIENT PAUSE. Originally reported by Chris Wj then proper action inspired by Itamar Haber. Reference: https://groups.google.com/forum/#!topic/redis-db/09B2EYwyVgk
-
Matt Stancliff authored
Sentinel needs to die with a more accurate error message when attempted to open a config from STDIN. See: https://groups.google.com/forum/#!topic/redis-db/sYx7VNMWaNM
-
Matt Stancliff authored
It has an important name, but nothing uses it...
-
David Palm authored
Also adds a fallthrough case for when given large values (like overflow numbers of 2^64 by mistake). Closes #858
-
antirez authored
-
cubicdaiya authored
According to the C standard, it is desirable to give the type 'void' to functions have no argument. Closes #1631
-
Kashif Rasul authored
Modified by @antirez since the original fix to genInfoString() looked weak. Probably the clang analyzer complained about `section` being possibly NULL, and strcasecmp() called with a NULL pointer. In the practice this can never happen, still for the sake of correctness the right fix is not to modify only the first call, but to set `section` to the value of "default" if it happens to be NULL. Closes #1660
-
antirez authored
Also quit ASAP when we are still loading a DB, since care is not needed in this special condition, especially for a SIGINT.
-
Matt Stancliff authored
-
- 18 Jul, 2014 3 commits
-
-
antirez authored
-
antirez authored
PING can now be called with an additional arugment, behaving exactly like the ECHO command. PING can now also be called in Pub/Sub mode (with one more more subscriptions to channels / patterns) in order to trigger the delivery of an asynchronous pong message with the optional payload. This fixes issue #420.
-
antirez authored
The code tested many times if a client had active Pub/Sub subscriptions by checking the length of a list and dictionary where the patterns and channels are stored. This was substituted with a client flag called REDIS_PUBSUB that is simpler to test for. Moreover in order to manage this flag some code was refactored. This commit is believed to have no effects in the behavior of the server.
-
- 14 Jul, 2014 1 commit
-
-
michael-grunder authored
Previously, the command definition for the OBJECT command specified a minimum of two args (and that it was variadic), which meant that if you sent this: OBJECT foo When cluster was enabled, it would result in an assertion/SEGFAULT when Redis was attempting to extract keys. It appears that OBJECT is not variadic, and only ever takes 3 args. https://gist.github.com/michael-grunder/25960ce1508396d0d36a
-
- 09 Jul, 2014 6 commits
-
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
We introduce the distinction between slow and fast commands since those are two different sources of latency. An O(1) or O(log N) command without side effects (can't trigger deletion of large objects as a side effect of its execution) if delayed is a symptom of inherent latency of the system. A non-fast command (commands that may run large O(N) computations) if delayed may just mean that the user is executing slow operations. The advices LATENCY should provide in this two different cases are different, so we log the two classes of commands in a separated way.
-
antirez authored
-
- 02 Jul, 2014 1 commit
-
-
antirez authored
-
- 27 Jun, 2014 1 commit
-
-
antirez authored
-