- 10 Feb, 2017 2 commits
-
-
minghang.zmh authored
-
flowly authored
update to upstream
-
- 09 Feb, 2017 1 commit
-
-
antirez authored
After investigating issue #3796, it was discovered that MIGRATE could call migrateCloseSocket() after the original MIGRATE c->argv was already rewritten as a DEL operation. As a result the host/port passed to migrateCloseSocket() could be anything, often a NULL pointer that gets deferenced crashing the server. Now the socket is closed at an earlier time when there is a socket error in a later stage where no retry will be performed, before we rewrite the argument vector. Moreover a check was added so that later, in the socket_err label, there is no further attempt at closing the socket if the argument was rewritten. This fix should resolve the bug reported in #3796.
-
- 01 Feb, 2017 2 commits
-
-
antirez authored
-
antirez authored
Ziplists had a bug that was discovered while investigating a different issue, resulting in a corrupted ziplist representation, and a likely segmentation foult and/or data corruption of the last element of the ziplist, once the ziplist is accessed again. The bug happens when a specific set of insertions / deletions is performed so that an entry is encoded to have a "prevlen" field (the length of the previous entry) of 5 bytes but with a count that could be encoded in a "prevlen" field of a since byte. This could happen when the "cascading update" process called by ziplistInsert()/ziplistDelete() in certain contitious forces the prevlen to be bigger than necessary in order to avoid too much data moving around. Once such an entry is generated, inserting a very small entry immediately before it will result in a resizing of the ziplist for a count smaller than the current ziplist length (which is a violation, inserting code expects the ziplist to get bigger actually). So an FF byte is inserted in a misplaced position. Moreover a realloc() is performed with a count smaller than the ziplist current length so the final bytes could be trashed as well. SECURITY IMPLICATIONS: Currently it looks like an attacker can only crash a Redis server by providing specifically choosen commands. However a FF byte is written and there are other memory operations that depend on a wrong count, so even if it is not immediately apparent how to mount an attack in order to execute code remotely, it is not impossible at all that this could be done. Attacks always get better... and we did not spent enough time in order to think how to exploit this issue, but security researchers or malicious attackers could.
-
- 30 Jan, 2017 2 commits
- 27 Jan, 2017 2 commits
-
-
Salvatore Sanfilippo authored
Don't divide by zero
-
Jan-Erik Rediger authored
Previously Redis crashed on `MEMORY DOCTOR` when it has no slaves attached. Fixes #3783
-
- 26 Jan, 2017 2 commits
-
-
Salvatore Sanfilippo authored
Change switch statment to if statment
-
miter authored
-
- 25 Jan, 2017 1 commit
-
-
Salvatore Sanfilippo authored
Verify pairs are provided after ZADD's subcommands
-
- 20 Jan, 2017 1 commit
-
-
Salvatore Sanfilippo authored
fix rare assertion in DEBUG DIGEST
-
- 18 Jan, 2017 2 commits
-
-
antirez authored
This header file is for libs, like ziplist.c, that we want to leave almost separted from the core. The panic() calls will be easy to delete in order to use such files outside, but the debugging info we gain are very valuable compared to simple assertions where it is not possible to print debugging info.
-
antirez authored
This is of great interest because allows us to print debugging informations that could be of useful when debugging, like in the following example: serverPanic("Unexpected encoding for object %d, %d", obj->type, obj->encoding);
-
- 13 Jan, 2017 2 commits
-
-
antirez authored
-
Salvatore Sanfilippo authored
Initialize help only in repl mode
-
- 12 Jan, 2017 3 commits
- 11 Jan, 2017 4 commits
- 10 Jan, 2017 2 commits
- 08 Jan, 2017 1 commit
-
-
Jan-Erik Rediger authored
-
- 02 Jan, 2017 1 commit
-
-
oranagra authored
-
- 30 Dec, 2016 1 commit
-
-
oranagra authored
-
- 24 Dec, 2016 1 commit
-
-
oranagra authored
getExpire calls dictFind which can do rehashing. found by calling computeDatasetDigest from serverCron and running the test suite.
-
- 21 Dec, 2016 1 commit
-
-
antirez authored
Close #3687.
-
- 20 Dec, 2016 7 commits
-
-
Salvatore Sanfilippo authored
fix the wrong description of intsetGet().
-
Salvatore Sanfilippo authored
Fix an article usage
-
antirez authored
-
Salvatore Sanfilippo authored
Fix missing brackets around encoding variable in ZIP_DECODE_LENGTH macro
-
antirez authored
We need to report all the points added into the set, not just the ones matching the Tcl distance algo.
-
antirez authored
The same thing observed in #3551 by gnethercutt also fixed for GEOHASH as the original PR did.
-
antirez authored
There were two cases outlined in issue #3512 and PR #3551 where the Geo API returned unexpected results: empty strings where NULL replies were expected, or a single null reply where an array was expected. This violates the Redis principle that Redis replies for existing keys or elements should be indistinguishable. This is technically an API breakage so will be merged only into 4.0 and specified in the changelog in the list of breaking compatibilities, even if it is not very likely that actual code will be affected, hopefully, since with the past behavior basically there was to acconut for *both* the possibilities, and the new behavior is always one of the two, but in a consistent way.
-
- 19 Dec, 2016 2 commits
-
-
Justin Carvalho authored
-
antirez authored
-