1. 10 Feb, 2017 2 commits
  2. 09 Feb, 2017 1 commit
    • antirez's avatar
      Fix MIGRATE closing of cached socket on error. · f917e0da
      antirez authored
      After investigating issue #3796, it was discovered that MIGRATE
      could call migrateCloseSocket() after the original MIGRATE c->argv
      was already rewritten as a DEL operation. As a result the host/port
      passed to migrateCloseSocket() could be anything, often a NULL pointer
      that gets deferenced crashing the server.
      
      Now the socket is closed at an earlier time when there is a socket
      error in a later stage where no retry will be performed, before we
      rewrite the argument vector. Moreover a check was added so that later,
      in the socket_err label, there is no further attempt at closing the
      socket if the argument was rewritten.
      
      This fix should resolve the bug reported in #3796.
      f917e0da
  3. 01 Feb, 2017 2 commits
    • antirez's avatar
      Fix ziplist fix... · 0dbfb1d1
      antirez authored
      0dbfb1d1
    • antirez's avatar
      Ziplist: insertion bug under particular conditions fixed. · c495d095
      antirez authored
      Ziplists had a bug that was discovered while investigating a different
      issue, resulting in a corrupted ziplist representation, and a likely
      segmentation foult and/or data corruption of the last element of the
      ziplist, once the ziplist is accessed again.
      
      The bug happens when a specific set of insertions / deletions is
      performed so that an entry is encoded to have a "prevlen" field (the
      length of the previous entry) of 5 bytes but with a count that could be
      encoded in a "prevlen" field of a since byte. This could happen when the
      "cascading update" process called by ziplistInsert()/ziplistDelete() in
      certain contitious forces the prevlen to be bigger than necessary in
      order to avoid too much data moving around.
      
      Once such an entry is generated, inserting a very small entry
      immediately before it will result in a resizing of the ziplist for a
      count smaller than the current ziplist length (which is a violation,
      inserting code expects the ziplist to get bigger actually). So an FF
      byte is inserted in a misplaced position. Moreover a realloc() is
      performed with a count smaller than the ziplist current length so the
      final bytes could be trashed as well.
      
      SECURITY IMPLICATIONS:
      
      Currently it looks like an attacker can only crash a Redis server by
      providing specifically choosen commands. However a FF byte is written
      and there are other memory operations that depend on a wrong count, so
      even if it is not immediately apparent how to mount an attack in order
      to execute code remotely, it is not impossible at all that this could be
      done. Attacks always get better... and we did not spent enough time in
      order to think how to exploit this issue, but security researchers
      or malicious attackers could.
      c495d095
  4. 30 Jan, 2017 2 commits
  5. 27 Jan, 2017 2 commits
  6. 26 Jan, 2017 2 commits
  7. 25 Jan, 2017 1 commit
  8. 20 Jan, 2017 1 commit
  9. 18 Jan, 2017 2 commits
    • antirez's avatar
      Add panic() into redisassert.h. · 17ac46ea
      antirez authored
      This header file is for libs, like ziplist.c, that we want to leave
      almost separted from the core. The panic() calls will be easy to delete
      in order to use such files outside, but the debugging info we gain are
      very valuable compared to simple assertions where it is not possible to
      print debugging info.
      17ac46ea
    • antirez's avatar
      serverPanic(): allow printf() alike formatting. · 53b8bf2c
      antirez authored
      This is of great interest because allows us to print debugging
      informations that could be of useful when debugging, like in the
      following example:
      
          serverPanic("Unexpected encoding for object %d, %d",
              obj->type, obj->encoding);
      53b8bf2c
  10. 13 Jan, 2017 2 commits
  11. 12 Jan, 2017 3 commits
  12. 11 Jan, 2017 4 commits
  13. 10 Jan, 2017 2 commits
  14. 08 Jan, 2017 1 commit
  15. 02 Jan, 2017 1 commit
  16. 30 Dec, 2016 1 commit
  17. 24 Dec, 2016 1 commit
    • oranagra's avatar
      fix rare assertion in DEBUG DIGEST · b2da5ea7
      oranagra authored
      getExpire calls dictFind which can do rehashing.
      found by calling computeDatasetDigest from serverCron and running the test suite.
      b2da5ea7
  18. 21 Dec, 2016 1 commit
  19. 20 Dec, 2016 7 commits
  20. 19 Dec, 2016 2 commits