- 24 Mar, 2014 1 commit
-
-
Matt Stancliff authored
This bug was introduced in 2e5c394f during a refactor. It took me a while to understand what was going on with the code, so I've refactored it further by: - Replacing boolean values with meaningful symbols - Replacing 'i' with a meaningful variable name - Adding the proper abort check - Factoring out now duplicated conditionals - Adding optional verbose logging (we're inside *four* different looping constructs, so it takes a while to figure out where all the moving parts are) - Updating comment for the section This fixes a problem when the number of master instances equaled the number of replica instances. Before, when there were equal numbers of both, nodes_count would go to zero, but the while loop would spin in i < @replicas because i would never be updated (because the nodes_list of each ip was length == 0, which triggered an endless loop of next -> i = 0 -> 0 < 1? -> true -> next -> i = 0 ...) Thanks to carlo who found this problem at: https://groups.google.com/forum/#!topic/redis-db/_WVVqDw5B7c
-
- 11 Mar, 2014 3 commits
-
-
antirez authored
See issue #1593. Thanks to @badboy for suggesting the direct client.call fix.
-
antirez authored
Example: ./redis-trib.rb call 192.168.1.11:7000 config get cluster-node-timeout
-
antirez authored
Example: if the user will try to configure a cluster with 9 nodes, asking for 1 slave for master, redis-trib will configure a 4 masters cluster with 1 slave each as usually, but this time will assign the spare node as a slave of one of the masters.
-
- 11 Feb, 2014 1 commit
-
-
antirez authored
-
- 10 Feb, 2014 6 commits
- 24 Jan, 2014 1 commit
-
-
antirez authored
-
- 17 Jan, 2014 5 commits
- 16 Jan, 2014 2 commits
- 17 Dec, 2013 1 commit
-
-
antirez authored
Later this should be configurable from the command line but at least now we use something more appropriate for our use case compared to the redis-rb default timeout.
-
- 07 Nov, 2013 1 commit
-
-
antirez authored
-
- 05 Nov, 2013 1 commit
-
-
antirez authored
-
- 11 Oct, 2013 1 commit
-
-
antirez authored
-
- 25 Sep, 2013 2 commits
- 26 Mar, 2013 1 commit
-
-
antirez authored
The hope is that the new one is more readable.
-
- 25 Mar, 2013 3 commits
- 22 Mar, 2013 6 commits
-
-
antirez authored
This is needed in order to colorize it as next step. We use conventions in output messages such as >>> This is an action *** This is a warning [ERR] This is an error [OK] That's fine And so forth, so that a color will be associated checking the first three chars.
-
antirez authored
Slot zero was hardcoded (!)
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
-
- 21 Mar, 2013 4 commits
- 19 Mar, 2013 1 commit
-
-
antirez authored
-