- 16 Jul, 2018 10 commits
-
-
Salvatore Sanfilippo authored
slave buffers were wasteful and incorrectly counted causing eviction
-
Salvatore Sanfilippo authored
Streams: correctly propagate xdel if needed
-
Oran Agra authored
A) slave buffers didn't count internal fragmentation and sds unused space, this caused them to induce eviction although we didn't mean for it. B) slave buffers were consuming about twice the memory of what they actually needed. - this was mainly due to sdsMakeRoomFor growing to twice as much as needed each time but networking.c not storing more than 16k (partially fixed recently in 237a38737). - besides it wasn't able to store half of the new string into one buffer and the other half into the next (so the above mentioned fix helped mainly for small items). - lastly, the sds buffers had up to 30% internal fragmentation that was wasted, consumed but not used. C) inefficient performance due to starting from a small string and reallocing many times. what i changed: - creating dedicated buffers for reply list, counting their size with zmalloc_size - when creating a new reply node from, preallocate it to at least 16k. - when appending a new reply to the buffer, first fill all the unused space of the previous node before starting a new one. other changes: - expose mem_not_counted_for_evict info field for the benefit of the test suite - add a test to make sure slave buffers are counted correctly and that they don't cause eviction
-
zhaozhao.zz authored
-
antirez authored
-
Salvatore Sanfilippo authored
Streams: free lp if all elements are deleted
-
antirez authored
Related to #5129.
-
Salvatore Sanfilippo authored
Streams: show last id for streams and groups
-
zhaozhao.zz authored
-
zhaozhao.zz authored
-
- 13 Jul, 2018 14 commits
-
-
Salvatore Sanfilippo authored
update leap year comment
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
-
andrewsensus authored
-
antirez authored
-
antirez authored
-
Salvatore Sanfilippo authored
Fix slowlog config
-
WuYunlong authored
-
WuYunlong authored
-
artix authored
-
artix authored
outputs a warning to the user.
-
artix authored
-
- 12 Jul, 2018 7 commits
-
-
Salvatore Sanfilippo authored
Delete unused role checking.
-
Shen Longxing authored
When check rdb file, it is unnecessary to check role.
-
Salvatore Sanfilippo authored
Remove unnecessary return statements
-
antirez authored
-
antirez authored
We don't want to increment the deliveries here, because the sysadmin reset the consumer group so the desire is likely to restart processing, and having the PEL polluted with old information is not useful but probably confusing. Related to #5111.
-
antirez authored
We don't really need to distinguish between the case the consumer is the same or is a different one.
-
Salvatore Sanfilippo authored
Streams: fix xreadgroup crash after xgroup SETID is sent.
-
- 11 Jul, 2018 2 commits
-
-
Salvatore Sanfilippo authored
Active defrag fixes for 32bit builds (again)
-
Oran Agra authored
* overflow in jemalloc fragmentation hint to the defragger
-
- 10 Jul, 2018 7 commits
-
-
Salvatore Sanfilippo authored
fix repeat argument issue and reduce unnessary loop times for redis-cli.
-
tengfeng authored
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
To simplify the semantics of blocking for a group, this commit changes the implementation to better match the description we provide of conusmer groups: blocking for > will make the consumer waiting for new elements in the group. However blocking for any other ID will always serve the local history of the consumer. However it must be noted that the > ID is actually an alias for the special ID ms/seq of UINT64_MAX,UINT64_MAX.
-
antirez authored
To detect when the group (or the whole key) is destroyed to send an error to the consumers blocked in such group is a problem, so we leave the consumers listening, the sysadmin is free to create or destroy groups assuming she/he knows what to do. However a client may be blocked in a given consumer group, that is later destroyed. Then the stream receives new elements. In that case there is no sane behavior to serve the consumer... but to report an error about the group no longer existing. More about detecting this synchronously and why it is not done: 1. Normally we don't do that, we leave clients blocked for other data types such as lists. 2. When we free a stream object there is no longer information about what was the key it was associated with, so while destroying the consumer groups we miss the info to unblock the clients in that moment. 3. Objects can be reclaimed in other threads where it is no longer safe to do client operations.
-