1. 09 Jan, 2019 6 commits
  2. 11 Dec, 2018 1 commit
  3. 07 Dec, 2018 2 commits
  4. 30 Nov, 2018 1 commit
  5. 25 Nov, 2018 2 commits
  6. 08 Nov, 2018 1 commit
  7. 09 Oct, 2018 1 commit
  8. 30 Jul, 2018 1 commit
  9. 02 Jul, 2018 1 commit
  10. 28 Jun, 2018 1 commit
  11. 18 Jun, 2018 1 commit
  12. 09 Jun, 2018 1 commit
  13. 08 Jun, 2018 1 commit
  14. 07 Jun, 2018 1 commit
  15. 02 Jun, 2018 1 commit
    • WuYunlong's avatar
      Fix DEBUG LOADAOF so that redis-server will not crash unexpectedly · 7d269d5e
      WuYunlong authored
      and will not be inconsistent after we call debug loadaof.
      Before this commit, there were 2 problems:
      
      1, When appendonly is set to no and there is not a appendonly file,
         redis-server will crash if we call DEBUG LOADAOF.
      2, When appendonly is set to no and there is a appendonly file,
         redis-server will hold different data after loading  appendonly
         file.
      7d269d5e
  16. 25 May, 2018 1 commit
  17. 29 Mar, 2018 1 commit
  18. 09 Jan, 2018 1 commit
  19. 06 Dec, 2017 1 commit
    • antirez's avatar
      Change indentation and other minor details of PR #4489. · 522760fa
      antirez authored
      The main change introduced by this commit is pretending that help
      arrays are more text than code, thus indenting them at level 0. This
      improves readability, and is an old practice when defining arrays of
      C strings describing text.
      
      Additionally a few useless return statements are removed, and the HELP
      subcommand capitalized when printed to the user.
      522760fa
  20. 04 Dec, 2017 2 commits
  21. 01 Dec, 2017 1 commit
  22. 28 Nov, 2017 2 commits
    • Itamar Haber's avatar
      Standardizes the 'help' subcommand · 59d52f7f
      Itamar Haber authored
      This adds a new `addReplyHelp` helper that's used by commands
      when returning a help text. The following commands have been
      touched: DEBUG, OBJECT, COMMAND, PUBSUB, SCRIPT and SLOWLOG.
      
      WIP
      
      Fix entry command table entry for OBJECT for HELP option.
      
      After #4472 the command may have just 2 arguments.
      
      Improve OBJECT HELP descriptions.
      
      See #4472.
      
      WIP 2
      
      WIP 3
      59d52f7f
    • Itamar Haber's avatar
      Standardizes arity handling of DEBUG · 8c7f90e9
      Itamar Haber authored
      8c7f90e9
  23. 20 Sep, 2017 1 commit
    • zhaozhao.zz's avatar
      PSYNC2: make persisiting replication info more solid · b541ccef
      zhaozhao.zz authored
      This commit is a reinforcement of commit c1c99e9f.
      
      1. Replication information can be stored when the RDB file is
      generated by a mater using server.slaveseldb when server.repl_backlog
      is not NULL, or set repl_stream_db be -1. That's safe, because
      NULL server.repl_backlog will trigger full synchronization,
      then master will send SELECT command to replicaiton stream.
      2. Only do rdbSave* when rsiptr is not NULL,
      if we do rdbSave* without rdbSaveInfo, slave will miss repl-stream-db.
      3. Save the replication informations also in the case of
      SAVE command, FLUSHALL command and DEBUG reload.
      b541ccef
  24. 06 Jul, 2017 1 commit
  25. 03 Jul, 2017 1 commit
  26. 20 Feb, 2017 1 commit
    • antirez's avatar
      Use SipHash hash function to mitigate HashDos attempts. · adeed29a
      antirez authored
      This change attempts to switch to an hash function which mitigates
      the effects of the HashDoS attack (denial of service attack trying
      to force data structures to worst case behavior) while at the same time
      providing Redis with an hash function that does not expect the input
      data to be word aligned, a condition no longer true now that sds.c
      strings have a varialbe length header.
      
      Note that it is possible sometimes that even using an hash function
      for which collisions cannot be generated without knowing the seed,
      special implementation details or the exposure of the seed in an
      indirect way (for example the ability to add elements to a Set and
      check the return in which Redis returns them with SMEMBERS) may
      make the attacker's life simpler in the process of trying to guess
      the correct seed, however the next step would be to switch to a
      log(N) data structure when too many items in a single bucket are
      detected: this seems like an overkill in the case of Redis.
      
      SPEED REGRESION TESTS:
      
      In order to verify that switching from MurmurHash to SipHash had
      no impact on speed, a set of benchmarks involving fast insertion
      of 5 million of keys were performed.
      
      The result shows Redis with SipHash in high pipelining conditions
      to be about 4% slower compared to using the previous hash function.
      However this could partially be related to the fact that the current
      implementation does not attempt to hash whole words at a time but
      reads single bytes, in order to have an output which is endian-netural
      and at the same time working on systems where unaligned memory accesses
      are a problem.
      
      Further X86 specific optimizations should be tested, the function
      may easily get at the same level of MurMurHash2 if a few optimizations
      are performed.
      adeed29a
  27. 18 Jan, 2017 1 commit
    • antirez's avatar
      serverPanic(): allow printf() alike formatting. · 53b8bf2c
      antirez authored
      This is of great interest because allows us to print debugging
      informations that could be of useful when debugging, like in the
      following example:
      
          serverPanic("Unexpected encoding for object %d, %d",
              obj->type, obj->encoding);
      53b8bf2c
  28. 02 Jan, 2017 1 commit
  29. 30 Dec, 2016 1 commit
  30. 24 Dec, 2016 1 commit
    • oranagra's avatar
      fix rare assertion in DEBUG DIGEST · b2da5ea7
      oranagra authored
      getExpire calls dictFind which can do rehashing.
      found by calling computeDatasetDigest from serverCron and running the test suite.
      b2da5ea7
  31. 16 Dec, 2016 1 commit