- 25 Mar, 2020 36 commits
-
-
Oran Agra authored
Redis refusing to run MULTI or EXEC during script timeout may cause partial transactions to run. 1) if the client sends MULTI+commands+EXEC in pipeline without waiting for response, but these arrive to the shards partially while there's a busy script, and partially after it eventually finishes: we'll end up running only part of the transaction (since multi was ignored, and exec would fail). 2) similar to the above if EXEC arrives during busy script, it'll be ignored and the client state remains in a transaction. the 3rd test which i added for a case where MULTI and EXEC are ok, and only the body arrives during busy script was already handled correctly since processCommand calls flagTransaction
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
-
bodong.ybd authored
-
antirez authored
-
Guy Benoish authored
-
hwware authored
-
Yossi Gottlieb authored
-
Yossi Gottlieb authored
-
Yossi Gottlieb authored
We assume accept handlers may choose to reject a connection and close it, but connAccept() callers can't distinguish between this state and other error states requiring connClose(). This makes it safe (and mandatory!) to always call connClose() if connAccept() fails, and safe for accept handlers to close connections (which will defer).
-
hwware authored
-
hwware authored
-
hwware authored
-
artix authored
-
박승현 authored
-
WuYunlong authored
Before this commit, when upgrading a replica, expired keys will not be loaded, thus causing replica having less keys in db. To this point, master and replica's keys is logically consistent. However, before the keys in master and replica are physically consistent, that is, they have the same dbsize, if master got a problem and the replica got promoted and becomes new master of that partition, and master updates a key which does not exist on master, but physically exists on the old master(new replica), the old master would refuse to update the key, thus causing master and replica data inconsistent. How could this happen? That's all because of the wrong judgement of roles while starting up the server. We can not use server.masterhost to judge if the server is master or replica, since it fails in cluster mode. When we start the server, we load rdb and do want to load expired keys, and do not want to have the ability to active expire keys, if it is a replica.
-
WuYunlong authored
-
antirez authored
-
antirez authored
This fixes issue #7011.
-
antirez authored
-
antirez authored
Note that this as a side effect fixes Sentinel "requirepass" mode.
-
antirez authored
-
zhaozhao.zz authored
-
zhaozhao.zz authored
-
antirez authored
-
antirez authored
-
zhaozhao.zz authored
-
antirez authored
-
chendianqiang authored
-
guodongxiaren authored
-
Itamar Haber authored
-
bodong.ybd authored
-
bodong.ybd authored
-
fengpf authored
-
- 12 Mar, 2020 4 commits
-
-
antirez authored
-
lifubang authored
Signed-off-by:
lifubang <lifubang@acmcoder.com>
-
lifubang authored
update linenoise to https://github.com/antirez/linenoise/tree/fc9667a81d43911a6690fb1e68c16e6e3bb8df05 Signed-off-by:
lifubang <lifubang@acmcoder.com>
-
Jamie Scott authored
Removing the default guidance in Redis.conf since this is not an available value.
-