1. 09 Jul, 2013 2 commits
    • antirez's avatar
      getClientPeerId() now reports errors. · e4c019e7
      antirez authored
      We now also use it in CLIENT KILL implementation.
      e4c019e7
    • antirez's avatar
      getClientPeerID introduced. · 5cdc5da9
      antirez authored
      The function returns an unique identifier for the client, as ip:port for
      IPv4 and IPv6 clients, or as path:0 for Unix socket clients.
      
      See the top comment in the function for more info.
      5cdc5da9
  2. 08 Jul, 2013 2 commits
    • Geoff Garside's avatar
      Update REDIS_CLUSTER_IPLEN to INET6_ADDRSTRLEN. · 6181455a
      Geoff Garside authored
      Change REDIS_CLUSTER_IPLEN to INET6_ADDRSTRLEN so that the clusterNode
      ip character buffer is big enough to hold an IPv6 address.
      6181455a
    • Geoff Garside's avatar
      Add macro to define clusterNode.ip buffer size. · 9cfa02fe
      Geoff Garside authored
      Add REDIS_CLUSTER_IPLEN macro to define the size of the clusterNode ip
      character array. Additionally use this macro in inet_ntop(3) calls where
      the size of the array was being defined manually.
      
      The REDIS_CLUSTER_IPLEN is defined as INET_ADDRSTRLEN which defines the
      correct size of a buffer to store an IPv4 address in. The
      INET_ADDRSTRLEN macro itself is defined in the <netinet/in.h> header
      file and should be portable across the majority of systems.
      9cfa02fe
  3. 05 Jul, 2013 1 commit
  4. 04 Jul, 2013 1 commit
  5. 28 Jun, 2013 1 commit
  6. 26 Jun, 2013 2 commits
  7. 24 Jun, 2013 2 commits
    • antirez's avatar
      Use the RSC to replicate EVALSHA unmodified. · f0bf5fd8
      antirez authored
      This commit uses the Replication Script Cache in order to avoid
      translating EVALSHA into EVAL whenever possible for both the AOF and
      slaves.
      f0bf5fd8
    • antirez's avatar
      Replication of scripts as EVALSHA: sha1 caching implemented. · 94ec7db4
      antirez authored
      This code is only responsible to take an LRU-evicted fixed length cache
      of SHA1 that we are sure all the slaves received.
      
      In this commit only the implementation is provided, but the Redis core
      does not use it to actually send EVALSHA to slaves when possible.
      94ec7db4
  8. 21 Jun, 2013 1 commit
    • antirez's avatar
      New API to force propagation. · 515a26bb
      antirez authored
      The old REDIS_CMD_FORCE_REPLICATION flag was removed from the
      implementation of Redis, now there is a new API to force specific
      executions of a command to be propagated to AOF / Replication link:
      
          void forceCommandPropagation(int flags);
      
      The new API is also compatible with Lua scripting, so a script that will
      execute commands that are forced to be propagated, will also be
      propagated itself accordingly even if no change to data is operated.
      
      As a side effect, this new design fixes the issue with scripts not able
      to propagate PUBLISH to slaves (issue #873).
      515a26bb
  9. 20 Jun, 2013 1 commit
    • antirez's avatar
      PUBSUB command implemented. · 455563fa
      antirez authored
      Currently it implements three subcommands:
      
      PUBSUB CHANNELS [<pattern>]    List channels with non-zero subscribers.
      PUBSUB NUMSUB [channel_1 ...]  List number of subscribers for channels.
      PUBSUB NUMPAT                  Return number of subscribed patterns.
      455563fa
  10. 12 Jun, 2013 1 commit
  11. 30 May, 2013 1 commit
  12. 27 May, 2013 3 commits
  13. 17 May, 2013 1 commit
  14. 15 May, 2013 1 commit
    • antirez's avatar
      Added a define for most configuration defaults. · 310dbba0
      antirez authored
      Also the logfile option was modified to always have an explicit value
      and to log to stdout when an empty string is used as log file.
      
      Previously there was special handling of the string "stdout" that set
      the logfile to NULL, this always required some special handling.
      310dbba0
  15. 13 May, 2013 2 commits
  16. 09 May, 2013 1 commit
  17. 08 May, 2013 1 commit
    • antirez's avatar
      Revert "use long long instead of size_t make it more safe" · 0ae1b5b0
      antirez authored
      This reverts commit 2c75f2cf.
      
      After further analysis, it is very unlikely that we'll raise the
      string size limit to > 512MB, and at the same time such big strings
      will be used in 32 bit systems.
      
      Better to revert to size_t so that 32 bit processors will not be
      forced to use a 64 bit counter in normal operations, that is currently
      completely useless.
      0ae1b5b0
  18. 07 May, 2013 2 commits
  19. 03 May, 2013 1 commit
    • antirez's avatar
      Cluster: link reconnection on delayed PONG reply. · 5c9f6d4f
      antirez authored
      When the PONG delay is half the cluster node timeout, the link gets
      disconnected (and later automatically reconnected) in order to ensure
      that it's not just a dead connection issue.
      
      However this operation is only performed if the link is old enough, in
      order to avoid to disconnect the same link again and again (and among
      the other problems, never receive the PONG because of that).
      
      Note: when the link is reconnected, the 'ping_sent' field is not updated
      even if a new ping is sent using the new connection, so we can still
      reliably detect a node ping timeout.
      5c9f6d4f
  20. 24 Apr, 2013 2 commits
  21. 09 Apr, 2013 2 commits
    • antirez's avatar
      Cluster: use server.cluster_node_timeout directly. · 68cf249f
      antirez authored
      We used to copy this value into the server.cluster structure, however this
      was not necessary.
      
      The reason why we don't directly use server.cluster->node_timeout is
      that things that can be configured via redis.conf need to be directly
      available in the server structure as server.cluster is allocated later
      only if needed in order to reduce the memory footprint of non-cluster
      instances.
      68cf249f
    • antirez's avatar
      ef4f25ff
  22. 04 Apr, 2013 3 commits
  23. 02 Apr, 2013 1 commit
    • antirez's avatar
      Throttle BGSAVE attempt on saving error. · b237de33
      antirez authored
      When a BGSAVE fails, Redis used to flood itself trying to BGSAVE at
      every next cron call, that is either 10 or 100 times per second
      depending on configuration and server version.
      
      This commit does not allow a new automatic BGSAVE attempt to be
      performed before a few seconds delay (currently 5).
      
      This avoids both the auto-flood problem and filling the disk with
      logs at a serious rate.
      
      The five seconds limit, considering a log entry of 200 bytes, will use
      less than 4 MB of disk space per day that is reasonable, the sysadmin
      should notice before of catastrofic events especially since by default
      Redis will stop serving write queries after the first failed BGSAVE.
      
      This fixes issue #849
      b237de33
  24. 27 Mar, 2013 1 commit
    • antirez's avatar
      DEBUG set-active-expire added. · 32a83c82
      antirez authored
      We need the ability to disable the activeExpireCycle() (active
      expired key collection) call for testing purposes.
      32a83c82
  25. 20 Mar, 2013 2 commits
    • antirez's avatar
      Cluster: new flag PROMOTED introduced. · 506f9a42
      antirez authored
      A slave node set this flag for itself when, after receiving authorization
      from the majority of nodes, it turns itself into a master.
      
      At the same time now this flag is tested by nodes receiving a PING
      message before reconfiguring after a failover event. This makes the
      system more robust: even if currently there is no way to manually turn
      a slave into a master it is possible that we'll have such a feature in
      the future, or that simply because of misconfiguration a node joins the
      cluster as master while others believe it's a slave. This alone is now
      no longer enough to trigger reconfiguration as other nodes will check
      for the PROMOTED flag.
      
      The PROMOTED flag is cleared every time the node is turned back into a
      replica of some other node.
      506f9a42
    • antirez's avatar
      Cluster: add sender flags in cluster bus messages header. · 026b9483
      antirez authored
      Sender flags were not propagated for the sender, but only for nodes in
      the gossip section. This is odd and in the next commits we'll need to
      get updated flags for the sender node, so this commit adds a new field
      in the cluster messages header.
      
      The message header is the same size as we reused some free space that
      was marked as 'unused' because of alignment concerns.
      026b9483
  26. 15 Mar, 2013 1 commit
    • antirez's avatar
      Cluster: slaves start failover with a small delay. · 1375b061
      antirez authored
      Redis Cluster can cope with a minority of nodes not informed about the
      failure of a master in time for some reason (netsplit or node not
      functioning properly, blocked, ...) however to wait a few seconds before
      to start the failover will make most "normal" failovers simpler as the
      FAIL message will propagate before the slave election happens.
      1375b061
  27. 14 Mar, 2013 1 commit