1. 20 Jan, 2014 1 commit
  2. 17 Jan, 2014 1 commit
  3. 16 Jan, 2014 2 commits
  4. 15 Jan, 2014 9 commits
    • antirez's avatar
      Cluster: use the node blacklist in CLUSTER FORGET. · 3e948970
      antirez authored
      CLUSTER FORGET is not useful if we can't remove a node from all the
      nodes of our cluster because of the Gossip protocol that keeps adding
      a given node to nodes where we already tried to remove it.
      
      So now CLUSTER FORGET implements a nodes blacklist that is set and
      checked by the Gossip section processing function. This way before a
      node is re-added at least 60 seconds must elapse since the FORGET
      execution.
      
      This means that redis-trib has some time to remove a node from a whole
      cluster. It is possible that in the future it will be uesful to raise
      the 60 sec figure to something bigger.
      3e948970
    • antirez's avatar
      Cluster: fix clusterBlacklistAddNode() by setting right expire time. · ccf268fa
      antirez authored
      The hash table value should be set to now + 60 seconds otherwise it
      expires immediately.
      ccf268fa
    • antirez's avatar
      Cluster: clusterBlacklistAddNode() key lookup fixed. · 4e186115
      antirez authored
      We can't lookup by node->name that's not an SDS string but a plain C
      array in the node structure.
      4e186115
    • antirez's avatar
    • antirez's avatar
      Cluster: set a minimum rejoin delay if node_timeout is too small. · a81340ab
      antirez authored
      The rejoin delay usually is the node timeout. However if the node
      timeout is too small, we set it to 500 milliseconds, that is a value
      chosen to be greater than most setups RTT / instances latency figures
      so that likely communication with other nodes happen before rejoining.
      a81340ab
    • antirez's avatar
      Cluster: periodically call clusterUpdateState() when cluster is down. · a687cbc1
      antirez authored
      Usually we update the cluster state (to understand if we should accept
      queries or reply with an error) only when there is a change in the state
      of the nodes. However for the "delayed rejoin" feature to work, that is,
      for a master to wait some time before accepting queries again after it
      rejoins the majority, we need to periodically update the last time when
      the node was partitioned away from the majority.
      
      With this commit if the cluster is down we update the state ten times
      per second.
      a687cbc1
    • antirez's avatar
      Cluster: range checking in getSlotOrReply() fixed. · 25ddefde
      antirez authored
      See issue #1426 on Github.
      25ddefde
    • antirez's avatar
      Cluster: ignore empty lines in nodes.conf. · fb659cd3
      antirez authored
      Even without the user messing manually with the file, it is still
      possible to have blank lines (just a single "\n" per line) because of
      how the nodes.conf update/write process works.
      fb659cd3
    • antirez's avatar
      Cluster: atomic update of nodes.conf file. · 6c63df30
      antirez authored
      The way the file was generated was unsafe and leaded to nodes.conf file
      corruption (zero length file) on server stop/crash during the creation
      of the file.
      
      The previous file update method was as simple as open with O_TRUNC
      followed by the write call. While the write call was a single one with
      the full payload, ensuring no half-written files for POSIX semantics,
      stopping the server just after the open call resulted into a zero-length
      file (all the nodes information lost!).
      6c63df30
  5. 14 Jan, 2014 1 commit
    • antirez's avatar
      Cluster: support to read from slave nodes. · 28273394
      antirez authored
      A client can enter a special cluster read-only mode using the READONLY
      command: if the client read from a slave instance after this command,
      for slots that are actually served by the instance's master, the queries
      will be processed without redirection, allowing clients to read from
      slaves (but without any kind fo read-after-write guarantee).
      
      The READWRITE command can be used in order to exit the readonly state.
      28273394
  6. 09 Jan, 2014 1 commit
  7. 25 Dec, 2013 1 commit
  8. 22 Dec, 2013 1 commit
    • antirez's avatar
      Redis Cluster: add repl_ping_slave_period to slave data validity time. · 66ec1412
      antirez authored
      When the configured node timeout is very small, the data validity time
      (maximum data age for a slave to try a failover) is too little (ten
      times the configured node timeout) when the replication link with the
      master is mostly idle. In this case we'll receive some data from the
      master only every server.repl_ping_slave_period to refresh the last
      interaction with the master.
      
      This commit adds to the max data validity time the slave ping period to
      avoid this problem of slaves sensing too old data without a good reason.
      However this max data validity time is likely a setting that should be
      configurable by the Redis Cluster user in a way completely independent
      from the node timeout.
      66ec1412
  9. 20 Dec, 2013 5 commits
  10. 17 Dec, 2013 6 commits
  11. 05 Dec, 2013 1 commit
  12. 02 Dec, 2013 1 commit
  13. 29 Nov, 2013 2 commits
  14. 08 Nov, 2013 6 commits
  15. 05 Nov, 2013 1 commit
  16. 11 Oct, 2013 1 commit