1. 04 Mar, 2013 3 commits
  2. 12 Feb, 2013 1 commit
  3. 11 Feb, 2013 7 commits
  4. 08 Feb, 2013 1 commit
  5. 07 Feb, 2013 1 commit
  6. 05 Feb, 2013 3 commits
    • antirez's avatar
      cf0191dc
    • charsyam's avatar
      Turn off TCP_NODELAY on the slave socket after SYNC. · 45b1b2f7
      charsyam authored
      Further details from @antirez:
      
      It was reported by @StopForumSpam on Twitter that the Redis replication
      link was strangely using multiple TCP packets for multiple commands.
      This wastes a lot of bandwidth and is due to the TCP_NODELAY option we
      enable on the socket after accepting a new connection.
      
      However the master -> slave channel is a one-way channel since Redis
      replication is asynchronous, so there is no point in trying to reduce
      the latency, we should aim to reduce the bandwidth. For this reason this
      commit introduces the ability to disable the nagle algorithm on the
      socket after a successful SYNC.
      
      This feature is off by default because the delay can be up to 40
      milliseconds with normally configured Linux kernels.
      45b1b2f7
    • Rock Li's avatar
      retval doesn't initalized · 8c0b9f77
      Rock Li authored
      If each if conditions are all fail, variable retval will under uninitlized
      8c0b9f77
  7. 04 Feb, 2013 1 commit
    • Gengliang Wang's avatar
      Fix a bug in srandmemberWithCountCommand() · 9ddd0f77
      Gengliang Wang authored
      In CASE 2, the call sunionDiffGenericCommand will involve the string "srandmember"
      > sadd foo one
      (integer 1)
      > sadd srandmember two
      (integer 2)
      > srandmember foo 3
      1)"one"
      2)"two"
      9ddd0f77
  8. 21 Jan, 2013 4 commits
    • antirez's avatar
      bfad381f
    • antirez's avatar
      UNSUBSCRIBE and PUNSUBSCRIBE: always provide a reply. · 742e580f
      antirez authored
      UNSUBSCRIBE and PUNSUBSCRIBE commands are designed to mass-unsubscribe
      the client respectively all the channels and patters if called without
      arguments.
      
      However when these functions are called without arguments, but there are
      no channels or patters we are subscribed to, the old behavior was to
      don't reply at all.
      
      This behavior is broken, as every command should always reply.
      Also it is possible that we are no longer subscribed to a channels but we
      are subscribed to patters or the other way around, and the client should
      be notified with the correct number of subscriptions.
      
      Also it is not pretty that sometimes we did not receive a reply at all
      in a redis-cli session from these commands, blocking redis-cli trying
      to read the reply.
      
      This fixes issue #714.
      742e580f
    • antirez's avatar
      Fixed a bug in memtest progress bar, that had no actual effects. · 1b0f2445
      antirez authored
      This closes issue #859, thanks to @erbenmo.
      1b0f2445
    • antirez's avatar
      Not every __sun has backtrace(). · 580f65a5
      antirez authored
      I don't know how to test for Open Solaris that has support for
      backtrace() so for now removing the #ifdef that breaks compilation under
      other Solaris flavors.
      580f65a5
  9. 19 Jan, 2013 8 commits
  10. 18 Jan, 2013 1 commit
    • Nathan Parry's avatar
      redis-cli --rdb fails if server sends a ping · 0f4dbd9a
      Nathan Parry authored
      Redis pings slaves in "pre-synchronization stage" with newlines. (See
      https://github.com/antirez/redis/blob/2.6.9/src/replication.c#L814)
      However, redis-cli does not expect this - it sees the newline as the end
      of the bulk length line, and ends up returning 0 as bulk the length.
      This manifests as the following when running redis-cli:
      
          $ ./src/redis-cli --rdb some_file
          SYNC sent to master, writing 0 bytes to 'some_file'
          Transfer finished with success.
      
      With this commit, we just ignore leading newlines while reading the bulk
      length line.
      
      To reproduce the problem, load enough data into Redis so that the
      preparation of the RDB snapshot takes long enough for a ping to occur
      while redis-cli is waiting for the data.
      0f4dbd9a
  11. 16 Jan, 2013 2 commits
  12. 15 Jan, 2013 3 commits
    • antirez's avatar
      Typo fixed, ASCI -> ASCII. · 1b2ac3b2
      antirez authored
      1b2ac3b2
    • antirez's avatar
      CLIENT GETNAME and CLIENT SETNAME introduced. · c5f23ca7
      antirez authored
      Sometimes it is much simpler to debug complex Redis installations if it
      is possible to assign clients a name that is displayed in the CLIENT
      LIST output.
      
      This is the case, for example, for "leaked" connections. The ability to
      provide a name to the client makes it quite trivial to understand what
      is the part of the code implementing the client not releasing the
      resources appropriately.
      
      Behavior:
      
          CLIENT SETNAME: set a name for the client, or remove the current
                          name if an empty name is set.
          CLIENT GETNAME: get the current name, or a nil.
          CLIENT LIST: now displays the client name if any.
      
      Thanks to Mark Gravell for pushing this idea forward.
      c5f23ca7
    • antirez's avatar
      Undo slave-master handshake when SLAVEOF sets a new slave. · 27abaa23
      antirez authored
      Issue #828 shows how Redis was not correctly undoing a non-blocking
      connection attempt with the previous master when the master was set to a
      new address using the SLAVEOF command.
      
      This was also a result of lack of refactoring, so now there is a
      function to cancel the non blocking handshake with the master.
      The new function is now used when SLAVEOF NO ONE is called or when
      SLAVEOF is used to set the master to a different address.
      27abaa23
  13. 11 Jan, 2013 1 commit
  14. 10 Jan, 2013 3 commits
  15. 03 Jan, 2013 1 commit