- 27 Oct, 2020 1 commit
-
-
Oran Agra authored
Similarly to EXPIREAT with TTL in the past, which implicitly deletes the key and return success, RESTORE should not store key that are already expired into the db. When used together with REPLACE it should emit a DEL to keyspace notification and replication stream. (cherry picked from commit 5977a948) (cherry picked from commit 95ba01b5)
-
- 05 Mar, 2020 2 commits
-
-
Guy Benoish authored
This commit solves the following bug: 127.0.0.1:6379> XGROUP CREATE x grp $ MKSTREAM OK 127.0.0.1:6379> XADD x 666 f v "666-0" 127.0.0.1:6379> XREADGROUP GROUP grp Alice BLOCK 0 STREAMS x > 1) 1) "x" 2) 1) 1) "666-0" 2) 1) "f" 2) "v" 127.0.0.1:6379> XADD x 667 f v "667-0" 127.0.0.1:6379> XDEL x 667 (integer) 1 127.0.0.1:6379> XREADGROUP GROUP grp Alice BLOCK 0 STREAMS x > 1) 1) "x" 2) (empty array) The root cause is that we use s->last_id in streamCompareID while we should use the last *valid* ID
-
Guy Benoish authored
This commit solves several edge cases that are related to exhausting the streamID limits: We should correctly calculate the succeeding streamID instead of blindly incrementing 'seq' This affects both XREAD and XADD. Other (unrelated) changes: Reply with a better error message when trying to add an entry to a stream that has exhausted last_id
-
- 19 Nov, 2019 4 commits
-
-
antirez authored
-
antirez authored
-
Guy Benoish authored
Calling XADD with 0-0 or 0 would result in creating an empty key and storing it in the database. Even worse, because XADD will reply with error the action will not be replicated, creating a master-replica inconsistency
-
Loris Cro authored
-
- 05 Sep, 2019 1 commit
-
- 14 May, 2019 1 commit
-
-
antirez authored
In fast systems "SLOWLOG RESET" is fast enough to don't be logged even when the time limit is "1" sometimes. Leading to false positives such as: [err]: SLOWLOG - can be disabled in tests/unit/slowlog.tcl Expected '1' to be equal to '0'
-
- 13 May, 2019 9 commits
-
-
zhaozhao.zz authored
-
Oran Agra authored
solving few replication related tests race conditions which fail on slow machines bugfix in slave buffers test: since the test is executed twice, each time with a different commands count, the threshold for the delta can't be a constant.
-
Yossi Gottlieb authored
-
Yossi Gottlieb authored
-
antirez authored
-
Yossi Gottlieb authored
Add a flag to automatically protect filters from being called recursively by their own module.
-
Yossi Gottlieb authored
A filter handle is returned and can be used to unregister a filter. In the future it can also be used to further configure or manipulate the filter. Filters are now automatically unregistered when a module unloads.
-
Yossi Gottlieb authored
-
Yossi Gottlieb authored
-
- 18 Mar, 2019 2 commits
- 13 Mar, 2019 2 commits
-
-
Steve Webster authored
-
Steve Webster authored
The XCLAIM docs state the XCLAIM increments the delivery counter for messages. This PR makes the code match the documentation - which seems like the desired behaviour - whilst still allowing RETRYCOUNT to be specified manually. My understanding of the way streamPropagateXCLAIM() works is that this change will safely propagate to replicas since retry count is pulled directly from the streamNACK struct. Fixes #5194
-
- 21 Dec, 2018 1 commit
-
-
antirez authored
-
- 11 Dec, 2018 3 commits
-
-
Oran Agra authored
-
Guy Benoish authored
-
Qu Chen authored
-
- 20 Nov, 2018 2 commits
- 17 Oct, 2018 5 commits
-
-
antirez authored
-
zhaozhao.zz authored
-
antirez authored
See #5426.
-
zhaozhao.zz authored
-
zhaozhao.zz authored
-
- 15 Oct, 2018 3 commits
- 09 Oct, 2018 1 commit
-
-
zhaozhao.zz authored
-
- 03 Oct, 2018 1 commit
-
- 14 Sep, 2018 2 commits