1. 27 Oct, 2020 1 commit
    • Oran Agra's avatar
      RESTORE ABSTTL won't store expired keys into the db (#7472) · e9c9e4c2
      Oran Agra authored
      Similarly to EXPIREAT with TTL in the past, which implicitly deletes the
      key and return success, RESTORE should not store key that are already
      expired into the db.
      When used together with REPLACE it should emit a DEL to keyspace
      notification and replication stream.
      
      (cherry picked from commit 5977a948)
      (cherry picked from commit 95ba01b5)
      e9c9e4c2
  2. 05 Mar, 2020 2 commits
    • Guy Benoish's avatar
      Blocking XREAD[GROUP] should always reply with valid data (or timeout) · 7f3fcedb
      Guy Benoish authored
      This commit solves the following bug:
      127.0.0.1:6379> XGROUP CREATE x grp $ MKSTREAM
      OK
      127.0.0.1:6379> XADD x 666 f v
      "666-0"
      127.0.0.1:6379> XREADGROUP GROUP grp Alice BLOCK 0 STREAMS x >
      1) 1) "x"
         2) 1) 1) "666-0"
               2) 1) "f"
                  2) "v"
      127.0.0.1:6379> XADD x 667 f v
      "667-0"
      127.0.0.1:6379> XDEL x 667
      (integer) 1
      127.0.0.1:6379> XREADGROUP GROUP grp Alice BLOCK 0 STREAMS x >
      1) 1) "x"
         2) (empty array)
      
      The root cause is that we use s->last_id in streamCompareID
      while we should use the last *valid* ID
      7f3fcedb
    • Guy Benoish's avatar
      Stream: Handle streamID-related edge cases · 89682d96
      Guy Benoish authored
      This commit solves several edge cases that are related to
      exhausting the streamID limits: We should correctly calculate
      the succeeding streamID instead of blindly incrementing 'seq'
      This affects both XREAD and XADD.
      
      Other (unrelated) changes:
      Reply with a better error message when trying to add an entry
      to a stream that has exhausted last_id
      89682d96
  3. 19 Nov, 2019 4 commits
  4. 05 Sep, 2019 1 commit
  5. 14 May, 2019 1 commit
    • antirez's avatar
      Test: fix slowlog test false positive. · 7ac7ffd5
      antirez authored
      In fast systems "SLOWLOG RESET" is fast enough to don't be logged even
      when the time limit is "1" sometimes. Leading to false positives such
      as:
      
      [err]: SLOWLOG - can be disabled in tests/unit/slowlog.tcl
      Expected '1' to be equal to '0'
      7ac7ffd5
  6. 13 May, 2019 9 commits
  7. 18 Mar, 2019 2 commits
  8. 13 Mar, 2019 2 commits
  9. 21 Dec, 2018 1 commit
  10. 11 Dec, 2018 3 commits
  11. 20 Nov, 2018 2 commits
  12. 17 Oct, 2018 5 commits
  13. 15 Oct, 2018 3 commits
  14. 09 Oct, 2018 1 commit
  15. 03 Oct, 2018 1 commit
  16. 14 Sep, 2018 2 commits