- 14 Apr, 2014 12 commits
-
-
antirez authored
Mostly by reordering opcodes check conditional by frequency of opcodes in larger sparse-encoded HLLs.
-
antirez authored
-
antirez authored
Bottleneck found profiling. Big run time improvement found when testing after the change.
-
antirez authored
-
antirez authored
As more values are added splitting ZERO or XZERO opcodes, try to merge adjacent VAL opcodes if they have the same value.
-
antirez authored
Now the macros will work with arguments such as "ptr+1".
-
antirez authored
-
antirez authored
Bulk length for registers was emitted too early, so if there was a bug the reply looked like a long array with just one element, blocking the client as result.
-
antirez authored
-
antirez authored
We want to promote if the total string size exceeds the resulting size after the upgrade.
-
antirez authored
The function checks if all the HLL_REGISTERS were processed during the convertion from sparse to dense encoding, returning REDIS_OK or REDIS_ERR to signal a corruption problem. A bug in PFDEBUG GETREG was fixed: when the object is converted to the dense representation we need to reassign the new pointer to the header structure pointer.
-
antirez authored
Provides a human readable description of the opcodes composing a run-length encoded HLL (sparse encoding). The command is only useful for debugging / development tasks.
-
- 13 Apr, 2014 3 commits
- 12 Apr, 2014 10 commits
-
-
antirez authored
sdsIncrLen() must be called anyway even if we are replacing the last oppcode of the sparse representation.
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
Two vars initialized to wrong values in createHLLObject().
-
antirez authored
-
antirez authored
The function didn't considered the fact that each XZERO opcode is two bytes.
-
antirez authored
-
antirez authored
-
- 11 Apr, 2014 4 commits
-
-
antirez authored
Code never tested, but the basic layout is shaped in this commit. Also missing: 1) Sparse -> Dense conversion function. 2) New HLL object creation using the sparse representation. 3) Implementation of PFMERGE for the sparse representation.
-
antirez authored
-
antirez authored
Also dense representation access macro renamed accordingly.
-
antirez authored
Metadata are now placed at the start of the representation as an header. There is a proper structure to access the representation. Still work to do in order to truly abstract the implementation from the representation, commands still work assuming dense representation.
-
- 10 Apr, 2014 1 commit
-
-
antirez authored
After running a few simulations with different alternative encodings, it was found that the VAL opcode performs better using 5 bits for the value and 2 bits for the run length, at least for cardinalities in the range of interest.
-
- 09 Apr, 2014 1 commit
-
-
antirez authored
-
- 04 Apr, 2014 2 commits
-
-
antirez authored
This will be a non-op most of the times since the object will be unshared / decoded, however it is more technically correct to start this way since the object may be decoded even in the read-only code path.
-
antirez authored
Using a seed of zero has the side effect of having the empty string hashing to what is a very special case in the context of HyperLogLog: a very long run of zeroes. This did not influenced the correctness of the result with 16k registers because of the harmonic mean, but still it is inconvenient that a so obvious value maps to a so special hash. The seed 0xadc83b19 is used instead, which is the first 64 bits of the SHA1 of the empty string. Reference: issue #1657.
-
- 03 Apr, 2014 6 commits
-
-
antirez authored
-
antirez authored
We need to guarantee that the last bit is 1, otherwise an element may hash to just zeroes with probability 1/(2^64) and trigger an infinite loop. See issue #1657.
-
antirez authored
-
antirez authored
The new command allows to get a dump of the registers stored into an HyperLogLog data structure for testing / debugging purposes.
-
antirez authored
-
antirez authored
-
- 02 Apr, 2014 1 commit
-
-
antirez authored
This will allow future changes like compressed representations. Currently the magic is not checked for performance reasons but this may change in the future, for example if we add new types encoded in strings that may have the same size of HyperLogLogs.
-