1. 11 Feb, 2015 4 commits
  2. 10 Feb, 2015 8 commits
  3. 02 Feb, 2015 1 commit
    • mattcollier's avatar
      Update redis-cli.c · 7db39b7f
      mattcollier authored
      Code was adding '\n'  (line 521) to the end of NIL values exlusively making csv output inconsistent.  Removed '\n'
      7db39b7f
  4. 30 Jan, 2015 3 commits
  5. 29 Jan, 2015 5 commits
  6. 22 Jan, 2015 12 commits
    • antirez's avatar
      The seed must be static in getRandomHexChars(). · 71da1b15
      antirez authored
      71da1b15
    • antirez's avatar
      counter must be static in getRandomHexChars(). · 4e73b305
      antirez authored
      4e73b305
    • antirez's avatar
      getRandomHexChars(): use /dev/urandom just to seed. · b25154a3
      antirez authored
      On Darwin /dev/urandom depletes terribly fast. This is not an issue
      normally, but with Redis Cluster we generate a lot of unique IDs, for
      example during nodes handshakes. Our IDs need just to be unique without
      other strong crypto requirements, so this commit turns the function into
      something that gets a 20 bytes seed from /dev/urandom, and produces the
      rest of the output just using SHA1 in counter mode.
      b25154a3
    • Matt Stancliff's avatar
      Fix cluster migrate memory leak · ebb07a0b
      Matt Stancliff authored
      Fixes valgrind error:
      48 bytes in 1 blocks are definitely lost in loss record 196 of 373
         at 0x4910D3: je_malloc (jemalloc.c:944)
         by 0x42807D: zmalloc (zmalloc.c:125)
         by 0x41FA0D: dictGetIterator (dict.c:543)
         by 0x41FA48: dictGetSafeIterator (dict.c:555)
         by 0x459B73: clusterHandleSlaveMigration (cluster.c:2776)
         by 0x45BF27: clusterCron (cluster.c:3123)
         by 0x423344: serverCron (redis.c:1239)
         by 0x41D6CD: aeProcessEvents (ae.c:311)
         by 0x41D8EA: aeMain (ae.c:455)
         by 0x41A84B: main (redis.c:3832)
      ebb07a0b
    • Matt Stancliff's avatar
      Fix potential invalid read past end of array · 98faed3a
      Matt Stancliff authored
      If array has N elements, we can't read +1 if we are already at N.
      
      Also, we need to move elements by their storage size in the array,
      not just by individual bytes.
      98faed3a
    • Matt Stancliff's avatar
      Fix cluster reset memory leak · 97ffeb7c
      Matt Stancliff authored
      [maybe] Fixes valgrind errors:
      32 bytes in 4 blocks are definitely lost in loss record 107 of 228
         at 0x80EA447: je_malloc (jemalloc.c:944)
         by 0x806E59C: zrealloc (zmalloc.c:125)
         by 0x80A9AFC: clusterSetMaster (cluster.c:801)
         by 0x80AEDC9: clusterCommand (cluster.c:3994)
         by 0x80682A5: call (redis.c:2049)
         by 0x8068A20: processCommand (redis.c:2309)
         by 0x8076497: processInputBuffer (networking.c:1143)
         by 0x8073BAF: readQueryFromClient (networking.c:1208)
         by 0x8060E98: aeProcessEvents (ae.c:412)
         by 0x806123B: aeMain (ae.c:455)
         by 0x806C3DB: main (redis.c:3832)
      
      64 bytes in 8 blocks are definitely lost in loss record 143 of 228
         at 0x80EA447: je_malloc (jemalloc.c:944)
         by 0x806E59C: zrealloc (zmalloc.c:125)
         by 0x80AAB40: clusterProcessPacket (cluster.c:801)
         by 0x80A847F: clusterReadHandler (cluster.c:1975)
         by 0x30000FF: ???
      
      80 bytes in 10 blocks are definitely lost in loss record 148 of 228
         at 0x80EA447: je_malloc (jemalloc.c:944)
         by 0x806E59C: zrealloc (zmalloc.c:125)
         by 0x80AAB40: clusterProcessPacket (cluster.c:801)
         by 0x80A847F: clusterReadHandler (cluster.c:1975)
         by 0x2FFFFFF: ???
      97ffeb7c
    • Matt Stancliff's avatar
      Fix sending uninitialized bytes · 4a36350d
      Matt Stancliff authored
      Fixes valgrind error:
      Syscall param write(buf) points to uninitialised byte(s)
         at 0x514C35D: ??? (syscall-template.S:81)
         by 0x456B81: clusterWriteHandler (cluster.c:1907)
         by 0x41D596: aeProcessEvents (ae.c:416)
         by 0x41D8EA: aeMain (ae.c:455)
         by 0x41A84B: main (redis.c:3832)
       Address 0x5f268e2 is 2,274 bytes inside a block of size 8,192 alloc'd
         at 0x4932D1: je_realloc (jemalloc.c:1297)
         by 0x428185: zrealloc (zmalloc.c:162)
         by 0x4269E0: sdsMakeRoomFor.part.0 (sds.c:142)
         by 0x426CD7: sdscatlen (sds.c:251)
         by 0x4579E7: clusterSendMessage (cluster.c:1995)
         by 0x45805A: clusterSendPing (cluster.c:2140)
         by 0x45BB03: clusterCron (cluster.c:2944)
         by 0x423344: serverCron (redis.c:1239)
         by 0x41D6CD: aeProcessEvents (ae.c:311)
         by 0x41D8EA: aeMain (ae.c:455)
         by 0x41A84B: main (redis.c:3832)
       Uninitialised value was created by a stack allocation
         at 0x457810: nodeUpdateAddressIfNeeded (cluster.c:1236)
      4a36350d
    • antirez's avatar
      Cluster: node deletion cleanup / centralization. · 0a3edcbe
      antirez authored
      0a3edcbe
    • antirez's avatar
      Cluster: set the slaves->slaveof filed to NULL when master is freed. · 5130c253
      antirez authored
      Related to issue #2289.
      5130c253
    • antirez's avatar
      luaRedisGenericCommand(): log error at WARNING level when re-entered. · 26698af3
      antirez authored
      Rationale is that when re-entering, it is likely due to Lua debugging
      hooks. Returning an error will be ignored in most cases, going totally
      unnoticed. With the log at least we leave a trace.
      
      Related to issue #2302.
      26698af3
    • antirez's avatar
      luaRedisGenericCommand() recursion: just return an error. · 9b92eddd
      antirez authored
      Instead of calling redisPanic() to abort the server.
      
      Related to issue #2302.
      9b92eddd
    • antirez's avatar
      Panic on recursive calls to luaRedisGenericCommand(). · 83a6cc33
      antirez authored
      Related to issue #2302.
      83a6cc33
  7. 21 Jan, 2015 1 commit
    • antirez's avatar
      AOF rewrite: set iterator var to NULL when freed. · 23cc0a3f
      antirez authored
      The cleanup code expects that if 'di' is not NULL, it is a valid
      iterator that should be freed.
      
      The result of this bug was a crash of the AOF rewriting process if an
      error occurred after the DBs data are written and the iterator is no
      longer valid.
      23cc0a3f
  8. 13 Jan, 2015 5 commits
    • antirez's avatar
      Redis 2.9.102 (3.0.0 Release Candidate 2). · 12dcd2d7
      antirez authored
      12dcd2d7
    • antirez's avatar
      Redis 2.9.102 (3.0.0 Release Candidate 2). · 063e0a88
      antirez authored
      063e0a88
    • antirez's avatar
      Cluster: fetch my IP even if msg is not MEET for the first time. · df1a7fc4
      antirez authored
      In order to avoid that misconfigured cluster nodes at some time may
      force an IP update on other nodes, it is required that nodes update
      their own address only on MEET messages. However it does not make sense
      to do this the first time a node is contacted and yet does not have an
      IP, we just risk that myself->ip remains not assigned if there are
      messages lost or cluster creation procedures that don't make sure
      everybody is targeted by at least one incoming MEET message.
      
      Also fix the logging of the IP switch avoiding the :-1 tail.
      df1a7fc4
    • antirez's avatar
      Cluster: clusterMsgDataGossip structure, explict padding + minor stuff. · 45e2a26d
      antirez authored
      Also explicitly set version to 0, add a protocol version define, improve
      comments in the gossip structure.
      
      Note that the structure layout is the same after the change, we are just
      making the padding explicit with an additional not used 16 bits field.
      So this commit is still able to talk with the previous versions of
      cluster nodes.
      45e2a26d
    • antirez's avatar
      Suppress valgrind error about write sending uninitialized data. · 799a3cca
      antirez authored
      Valgrind checks that the buffers we transfer via syscalls are all
      composed of bytes actually initialized. This is useful, it makes we able
      to avoid leaking informations in non initialized parts fo messages
      transferred to other hosts. This commit fixes one of such issues.
      799a3cca
  9. 12 Jan, 2015 1 commit
    • antirez's avatar
      Cluster: initialize mf_end. · 1584c7a3
      antirez authored
      Can't be initialized by resetManualFailover() since it's actual state
      the function uses, so we need to initialize it at startup time. Not
      really a bug in practical terms, but showed up into valgrind and is not
      technically correct anyway.
      1584c7a3