1. 12 Dec, 2017 1 commit
  2. 06 Dec, 2017 1 commit
    • antirez's avatar
      Change indentation and other minor details of PR #4489. · 522760fa
      antirez authored
      The main change introduced by this commit is pretending that help
      arrays are more text than code, thus indenting them at level 0. This
      improves readability, and is an old practice when defining arrays of
      C strings describing text.
      
      Additionally a few useless return statements are removed, and the HELP
      subcommand capitalized when printed to the user.
      522760fa
  3. 05 Dec, 2017 14 commits
  4. 04 Dec, 2017 9 commits
    • Salvatore Sanfilippo's avatar
      Merge pull request #4506 from soloestoy/quicklist-int-problem · e6c3bcf9
      Salvatore Sanfilippo authored
      Quicklist int problem
      e6c3bcf9
    • zhaozhao.zz's avatar
      b9491b65
    • zhaozhao.zz's avatar
      664bbfe7
    • antirez's avatar
      2869284e
    • antirez's avatar
      Refactoring: improve luaCreateFunction() API. · 60d26acf
      antirez authored
      The function in its initial form, and after the fixes for the PSYNC2
      bugs, required code duplication in multiple spots. This commit modifies
      it in order to always compute the script name independently, and to
      return the SDS of the SHA of the body: this way it can be used in all
      the places, including for SCRIPT LOAD, without duplicating the code to
      create the Lua function name. Note that this requires to re-compute the
      body SHA1 in the case of EVAL seeing a script for the first time, but
      this should not change scripting performance in any way because new
      scripts definition is a rare event happening the first time a script is
      seen, and the SHA1 computation is anyway not a very slow process against
      the typical Redis script and compared to the actua Lua byte compiling of
      the body.
      
      Note that the function used to assert() if a duplicated script was
      loaded, however actually now two times over three, we want the function
      to handle duplicated scripts just fine: this happens in SCRIPT LOAD and
      in RDB AUX "lua" loading. Moreover the assert was not defending against
      some obvious failure mode, so now the function always tests against
      already defined functions at start.
      60d26acf
    • antirez's avatar
      Remove useless variable check from luaCreateFunction(). · c6eca690
      antirez authored
      The block is already inside if (allow_dup).
      c6eca690
    • antirez's avatar
      Fix issue #4505, Lua RDB AUX field loading of existing scripts. · 68681f2b
      antirez authored
      Unfortunately, as outlined by @soloestoy in #4505, "lua" AUX RDB field
      loading in case of duplicated script was still broken. This commit fixes
      this problem and also a memory leak introduced by the past commit.
      
      Note that now we have a regression test able to duplicate the issue, so
      this commit was actually tested against the regression. The original PR
      also had a valid fix, but I prefer to hide the details of scripting.c
      outside scripting.c, and later "SCRIPT LOAD" should also be able to use
      the function luaCreateFunction() instead of redoing the work.
      68681f2b
    • antirez's avatar
      6f0b19bc
    • antirez's avatar
      DEBUG change-repl-id implemented. · 6a1bf07a
      antirez authored
      With PSYNC2 to force a full SYNC in tests is hard. With this new DEBUG
      subcommand we just need to call it and then CLIENT KILL TYPE master in
      the slave.
      6a1bf07a
  5. 03 Dec, 2017 4 commits
  6. 01 Dec, 2017 11 commits