- 15 Feb, 2018 10 commits
-
-
Dvir Volk authored
-
Dvir Volk authored
-
Dvir Volk authored
-
Dvir Volk authored
-
Dvir Volk authored
-
Dvir Volk authored
-
Dvir Volk authored
-
Dvir Volk authored
-
antirez authored
See #3832.
-
oranagra authored
since slave isn't replying to it's master, these errors go unnoticed. since we don't expect the master to send garbadge to the slave, this should be safe. (as long as we don't log OOM errors there)
-
- 13 Feb, 2018 5 commits
-
-
charsyam authored
-
Guy Benoish authored
-
antirez authored
See #3858.
-
Guy Benoish authored
It is possible to do BGREWRITEAOF even if appendonly=no. This is by design. stopAppendonly() didn't turn off aof_rewrite_scheduled (it can be turned on again by BGREWRITEAOF even while appendonly is off anyway). After configuring `appendonly yes` it will see that the state is AOF_OFF, there's no RDB fork, so it will do rewriteAppendOnlyFileBackground() which will fail since the aof_child_pid is set (was scheduled and started by cron). Solution: stopAppendonly() will turn off the schedule flag (regardless of who asked for it). startAppendonly() will terminate any existing fork and start a new one (so it is the most recent).
-
Oran Agra authored
in some cases LATENCY HISTORY reported latency that was higher than the max latency reported by LATENCY LATEST / DOCTOR
-
- 02 Feb, 2018 2 commits
- 24 Jan, 2018 5 commits
-
-
antirez authored
-
jianqingdu authored
fix not call va_end when syncWrite() failed in sendSynchronousCommand()
-
Yusaku Kaneta authored
-
Mark Nunberg authored
Older versions might not have this function.
-
antirez authored
-
- 18 Jan, 2018 18 commits
-
-
antirez authored
-
Guy Benoish authored
When feeding the master with a high rate traffic the the slave's feed is much slower. This causes the replication buffer to grow (indefinitely) which leads to slave disconnection. The problem is that writeToClient() decides to stop writing after NET_MAX_WRITES_PER_EVENT writes (In order to be fair to clients). We should ignore this when the client is a slave. It's better if clients wait longer, the alternative is that the slave has no chance to stay in sync in this situation.
-
antirez authored
See #3462 and related PRs. We use a simple algorithm to calculate the level of affinity violation, and then an optimizer that performs random swaps until things improve.
-
antirez authored
The behavior is well specified by the code itself.
-
heqin authored
-
antirez authored
-
qinchao authored
, see issue: https://github.com/antirez/redis/issues/4587
-
Oran Agra authored
after a slave is promoted (assuming it has no slaves and it booted over an hour ago), it will lose it's replication backlog at the next replication cron, rather than waiting for slaves to connect to it. so on a simple master/slave faiover, if the new slave doesn't connect immediately, it may be too later and PSYNC2 will fail.
-
zhaozhao.zz authored
-
antirez authored
-
zhaozhao.zz authored
-
antirez authored
This fixes a crash with Redis Cluster when OBJECT is mis-used, because getKeysUsingCommandTable() will call serverPanic() detecting we are accessing an invalid argument in the case "OBJECT foo" is called. This bug was introduced when OBJECT HELP was introduced, because the key argument is set fixed at index 2 in the command table, however now OBJECT may be called with an insufficient number of arguments to extract the key. The "Right Thing" would be to have a specific function to extract keys from the OBJECT command, however this is kinda of an overkill, so I preferred to make getKeysUsingCommandTable() more robust and just return no keys when it's not possible to honor the command table, because new commands are often added and also there are a number with an HELP subcommand violating the normal form, and crashing for this trivial reason or having many command-specific key extraction functions is not great.
-
antirez authored
-
antirez authored
We already had client buffer limits exported as configuration options. Stick with the naming scheme already used. See #4568.
-
antirez authored
Related to #4568.
-
gnuhpc authored
-
Dvir Volk authored
-
zhaozhao.zz authored
-