- 06 Nov, 2013 1 commit
-
-
antirez authored
-
- 05 Nov, 2013 7 commits
-
-
antirez authored
Thanks to @badboy for reporting it.
-
antirez authored
The previous implementation of SCAN parsed the cursor in the generic function implementing SCAN, SSCAN, HSCAN and ZSCAN. The actual higher-level command implementation only checked for empty keys and return ASAP in that case. The result was that inverting the arguments of, for instance, SSCAN for example and write: SSCAN 0 key Instead of SSCAN key 0 Resulted into no error, since 0 is a non-existing key name very likely. Just the iterator returned no elements at all. In order to fix this issue the code was refactored to extract the function to parse the cursor and return the error. Every higher level command implementation now parses the cursor and later checks if the key exist or not.
-
antirez authored
The previous implementation assumed that the first call always happens with cursor set to 0, this may not be the case, and we want to return 0 anyway otherwise the (broken) client code will loop forever.
-
antirez authored
-
antirez authored
This fixes issue #1360 and #1362.
-
antirez authored
-
antirez authored
-
- 31 Oct, 2013 3 commits
- 29 Oct, 2013 21 commits
-
-
antirez authored
Thanks to @badboy for reporting.
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
Sorting the output helps when we want to turn a non-deterministic into a deterministic command, in that case this is not possible.
-
antirez authored
The new implementation is capable of iterating the keyspace but also sets, hashes, and sorted sets, and can be used to implement SSCAN, ZSCAN and HSCAN.
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
-
Pieter Noordhuis authored
The irrelevant bits shouldn't be masked to 1. This can result in slots being skipped when the hash table is resized between calls to the iterator.
-
Pieter Noordhuis authored
-
Pieter Noordhuis authored
-
- 28 Oct, 2013 1 commit
-
-
antirez authored
-
- 09 Oct, 2013 1 commit
-
-
antirez authored
-
- 04 Oct, 2013 4 commits
-
-
antirez authored
Sometimes when we resurrect a cached master after a successful partial resynchronization attempt, there is pending data in the output buffers of the client structure representing the master (likely REPLCONF ACK commands). If we don't reinstall the write handler, it will never be installed again by addReply*() family functions as they'll assume that if there is already data pending, the write handler is already installed. This bug caused some slaves after a successful partial sync to never send REPLCONF ACK, and continuously being detected as timing out by the master, with a disconnection / reconnection loop.
-
antirez authored
Since we started sending REPLCONF ACK from slaves to masters, the lastinteraction field of the client structure is always refreshed as soon as there is room in the socket output buffer, so masters in timeout are detected with too much delay (the socket buffer takes a lot of time to be filled by small REPLCONF ACK <number> entries). This commit only counts data received as interactions with a master, solving the issue.
-
antirez authored
There was a bug that over-esteemed the amount of backlog available, however this could only happen when a slave was asking for an offset that was in the "future" compared to the master replication backlog. Now this case is handled well and logged as an incident in the master log file.
-
antirez authored
-
- 26 Sep, 2013 1 commit
-
-
Michel Martens authored
-
- 17 Sep, 2013 1 commit
-
-
antirez authored
-