- 31 Oct, 2017 1 commit
-
-
antirez authored
There was not enough sanity checking in the code loading the slots of Redis Cluster from the nodes.conf file, this resulted into the attacker's ability to write data at random addresses in the process memory, by manipulating the index of the array. The bug seems exploitable using the following techique: the config file may be altered so that one of the nodes gets, as node ID (which is the first field inside the structure) some data that is actually executable: then by writing this address in selected places, this node ID part can be executed after a jump. So it is mostly just a matter of effort in order to exploit the bug. In practice however the issue is not very critical because the bug requires an unprivileged user to be able to modify the Redis cluster nodes configuration, and at the same time this should result in some gain. However Redis normally is unprivileged as well. Yet much better to have this fixed indeed. Fix #4278.
-
- 30 Oct, 2017 2 commits
-
-
antirez authored
-
antirez authored
Certain checks were useless, at the same time certain malformed inputs were accepted without problems (emtpy strings parsed as zero). Cases where strtod() returns ERANGE but we still want to parse the input where ok in getDoubleFromObject() but not in the long variant. As a side effect of these fixes, this commit fixes #4391.
-
- 28 Sep, 2017 2 commits
-
-
antirez authored
-
Salvatore Sanfilippo authored
Module Context flags
-
- 27 Sep, 2017 3 commits
- 21 Sep, 2017 3 commits
-
-
antirez authored
-
Salvatore Sanfilippo authored
Lazyfree: avoid memory leak when free slowlog entry
-
zhaozhao.zz authored
-
- 20 Sep, 2017 2 commits
-
-
antirez authored
-
zhaozhao.zz authored
This commit is a reinforcement of commit c1c99e9f. 1. Replication information can be stored when the RDB file is generated by a mater using server.slaveseldb when server.repl_backlog is not NULL, or set repl_stream_db be -1. That's safe, because NULL server.repl_backlog will trigger full synchronization, then master will send SELECT command to replicaiton stream. 2. Only do rdbSave* when rsiptr is not NULL, if we do rdbSave* without rdbSaveInfo, slave will miss repl-stream-db. 3. Save the replication informations also in the case of SAVE command, FLUSHALL command and DEBUG reload.
-
- 19 Sep, 2017 3 commits
-
-
antirez authored
This commit attempts to fix a number of bugs reported in #4316. They are related to the way replication info like replication ID, offsets, and currently selected DB in the master client, are stored and loaded by Redis. In order to avoid inconsistencies the changes in this commit try to enforce that: 1. Replication information are only stored when the RDB file is generated by a slave that has a valid 'master' client, so that we can always extract the currently selected DB. 2. When replication informations are persisted in the RDB file, all the info for a successful PSYNC or nothing is persisted. 3. The RDB replication informations are only loaded if the instance is configured as a slave, otherwise a master can start with IDs that relate to a different history of the data set, and stil retain such IDs in the future while receiving unrelated writes.
-
antirez authored
-
antirez authored
A slave may be started with an RDB file able to provide enough slave to perform a successful partial SYNC with its master. However in such a case, how outlined in issue #4268, the slave backlog will not be started, since it was only initialized on full syncs attempts. This creates different problems with successive PSYNC attempts that will always result in full synchronizations. Thanks to @fdingiit for discovering the issue.
-
- 18 Sep, 2017 3 commits
-
-
Salvatore Sanfilippo authored
redis-benchmark: default value size usage update.
-
Salvatore Sanfilippo authored
Remove Duplicate Processing
-
Salvatore Sanfilippo authored
Flush append only buffers before existing.
-
- 17 Sep, 2017 1 commit
-
-
Oran Agra authored
when SHUTDOWN command is recived it is possible that some of the recent command were not yet flushed from the AOF buffer, and the server experiences data loss at shutdown.
-
- 03 Aug, 2017 2 commits
-
-
Salvatore Sanfilippo authored
Add missing fclose()
-
jybaek authored
-
- 02 Aug, 2017 1 commit
-
-
Salvatore Sanfilippo authored
Changes command stats iteration to being dict-based
-
- 28 Jul, 2017 1 commit
-
-
antirez authored
-
- 25 Jul, 2017 1 commit
-
-
Mota authored
default size of SET/GET value in usage should be 3 bytes as in main code.
-
- 24 Jul, 2017 8 commits
-
-
Salvatore Sanfilippo authored
Don't use extended Regexp Syntax
-
Salvatore Sanfilippo authored
Check that the whole first argument is a number
-
Salvatore Sanfilippo authored
Correct proceding -> proceeding typo.
-
Salvatore Sanfilippo authored
fix rewrite config: auto-aof-rewrite-min-size
-
Salvatore Sanfilippo authored
Fix missing '-' in redis-benchmark help output (Issue #1996)
-
Salvatore Sanfilippo authored
fix mismatch argument and return wrong value of clusterDelNodeSlots
-
Salvatore Sanfilippo authored
Fix lua ldb command log
-
liangsijian authored
-
- 23 Jul, 2017 2 commits
-
-
antirez authored
Lua scripting does not support calling blocking commands, however all the native Redis commands are flagged as "s" (no scripting flag), so this is not possible at all. With modules there is no such mechanism in order to flag a command as non callable by the Lua scripting engine, moreover we cannot trust the modules users from complying all the times: it is likely that modules will be released to have blocking commands without such commands being flagged correctly, even if we provide a way to signal this fact. This commit attempts to address the problem in a short term way, by detecting that a module is trying to block in the context of the Lua scripting engine client, and preventing to do this. The module will actually believe to block as usually, but what happens is that the Lua script receives an error immediately, and the background call is ignored by the Redis engine (if not for the cleanup callbacks, once it unblocks). Long term, the more likely solution, is to introduce a new call called RedisModule_GetClientFlags(), so that a command can detect if the caller is a Lua script, and return an error, or avoid blocking at all. Being the blocking API experimental right now, more work is needed in this regard in order to reach a level well blocking module commands and all the other Redis subsystems interact peacefully. Now the effect is like the following: 127.0.0.1:6379> eval "redis.call('hello.block',1,5000)" 0 (error) ERR Error running script (call to f_b5ba35ff97bc1ef23debc4d6e9fd802da187ed53): @user_script:1: ERR Blocking module command called from Lua script This commit fixes issue #4127 in the short term.
-
antirez authored
-
- 20 Jul, 2017 3 commits
-
-
antirez authored
This function failed when an internal-only flag was set as an only flag in a node: the string was trimmed expecting a final comma before exiting the function, causing a crash. See issue #4142. Moreover generation of flags representation only needed at DEBUG log level was always performed: a waste of CPU time. This is fixed as well by this commit.
-
antirez authored
The function cache was not working at all, and the function returned wrong values if there where two or more modules exporting native data types. See issue #4131 for more details.
-
Leon Chen authored
-
- 18 Jul, 2017 1 commit
-
-
Leon Chen authored
-
- 15 Jul, 2017 1 commit
-
-
WuYunlong authored
-