- 04 May, 2015 2 commits
-
-
antirez authored
Should not be an issue given that the precision is the second here, at least if we are using a decent HZ value and the cached time refreshes enough times. So the cached time is only used if HZ is >= 10.
-
antirez authored
Commands may use cached time when the precision is not vital. It is a good idea to refresh it from time to time during the execution of long running scripts or transactions composed of quite a lot of commands.
-
- 30 Apr, 2015 1 commit
-
-
antirez authored
mstime() is not going to change significantly every 16 iterations, so now we update `now` with the current milliseconds time only when we check if the time limit was reached.
-
- 29 Apr, 2015 2 commits
-
-
antirez authored
When the key expires far in the future compared to the cached time in server.mstime, calling mstime(), that calls gettimeofday(), should not be very useful. Instead when we are near the expire, we want the additional precision. This commit is related to issue #2552.
-
antirez authored
This commit allows to avoid two mstime() calls inside the call() function, when the following conditions are true: 1. slowlog is disabled. 2. latency monitoring is disabled. 3. command time acconuting is disabled. Note that '3' was not configurable, this patch just disable it without really allowing the user to turn it on, since this is currently an experiment. If the commit will be merged into unstable, proper support to configure this parameter will be added. Related to issue #2552.
-
- 28 Apr, 2015 1 commit
-
-
antirez authored
This fixes issue #2535, that was actually an hiredis library bug (I submitted an issue and fix to the redis/hiredis repo as well). When an asynchronous hiredis connection subscribes to a Pub/Sub channel and gets an error, and in other related conditions, the function redisProcessCallbacks() enters a code path where the link is disconnected, however the function returns before freeing the allocated reply object. This causes a memory leak. The memory leak was trivial to trigger in Redis Sentinel, which uses hiredis, every time we tried to subscribe to an instance that required a password, in case the Sentinel was configured either with the wrong password or without password at all. In this case, the -AUTH error caused the leaking code path to be executed. It was verified with Valgrind that after this change the leak no longer happens in Sentinel with a misconfigured authentication password.
-
- 27 Apr, 2015 1 commit
-
-
antirez authored
-
- 01 Apr, 2015 1 commit
-
-
Oran Agra authored
master was closing the connection if the RDB transfer took long time. and also sent PINGs to the slave before it got the initial ACK, in which case the slave wouldn't be able to find the EOF marker.
-
- 27 Mar, 2015 1 commit
-
-
antirez authored
-
- 24 Mar, 2015 1 commit
-
-
antirez authored
Bug as old as Redis and blocking operations. It's hard to trigger since only happens on instance role switch, but the results are quite bad since an inconsistency between master and slave is created. How to trigger the bug is a good description of the bug itself. 1. Client does "BLPOP mylist 0" in master. 2. Master is turned into slave, that replicates from New-Master. 3. Client does "LPUSH mylist foo" in New-Master. 4. New-Master propagates write to slave. 5. Slave receives the LPUSH, the blocked client get served. Now Master "mylist" key has "foo", Slave "mylist" key is empty. Highlights: * At step "2" above, the client remains attached, basically escaping any check performed during command dispatch: read only slave, in that case. * At step "5" the slave (that was the master), serves the blocked client consuming a list element, which is not consumed on the master side. This scenario is technically likely to happen during failovers, however since Redis Sentinel already disconnects clients using the CLIENT command when changing the role of the instance, the bug is avoided in Sentinel deployments. Closes #2473.
-
- 08 Mar, 2015 1 commit
-
-
antirez authored
-
- 04 Mar, 2015 1 commit
-
-
antirez authored
Itereator misuse due to analyzeLatencyForEvent() accessing the dictionary during the iteration, without the iterator being reclared as safe.
-
- 10 Feb, 2015 9 commits
-
-
Charles Hooper authored
-
antirez authored
-
antirez authored
--stat mode already used to reconnect automatically if the server is no longer available. This is useful since this is an interactive mode used for debugging, however the same applies to --latency and --latency-dist modes, so now both use the reconnecting command execution as well. The reconnection code was modified to use basic VT100 escape sequences in order to play better with different kinds of output on the screen when the reconnection happens, and to hide the reconnection attempt output when finally the reconnection happens.
-
antirez authored
So far not able to find a color palette within the 256 colors which is not confusing. However I believe it is a possible task, so will try better later.
-
antirez authored
Still not happy with the result but low grays are hard to see in certain monitors with a non perfect gamma.
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
This test on Linux was extremely slow, since in Tcl we can't enable easily tcp-nodelay, so the busy loop used to take *a lot* with bigger writes. Fixed using pipelining.
-
- 02 Feb, 2015 1 commit
-
-
mattcollier authored
Code was adding '\n' (line 521) to the end of NIL values exlusively making csv output inconsistent. Removed '\n'
-
- 22 Jan, 2015 3 commits
-
-
antirez authored
Rationale is that when re-entering, it is likely due to Lua debugging hooks. Returning an error will be ignored in most cases, going totally unnoticed. With the log at least we leave a trace. Related to issue #2302.
-
antirez authored
Instead of calling redisPanic() to abort the server. Related to issue #2302.
-
antirez authored
Related to issue #2302.
-
- 21 Jan, 2015 1 commit
-
-
antirez authored
The cleanup code expects that if 'di' is not NULL, it is a valid iterator that should be freed. The result of this bug was a crash of the AOF rewriting process if an error occurred after the DBs data are written and the iterator is no longer valid.
-
- 09 Jan, 2015 2 commits
- 08 Jan, 2015 2 commits
-
-
antirez authored
-
Jungtaek Lim authored
-
- 23 Dec, 2014 1 commit
-
-
antirez authored
1. Server unxtime may remain not updated while loading AOF, so ETA is not updated correctly. 2. Number of processed byte was not initialized. 3. Possible division by zero condition (likely cause of issue #1932).
-
- 22 Dec, 2014 1 commit
-
-
Alon Diamant authored
-
- 19 Dec, 2014 1 commit
-
-
antirez authored
Fixes issue #2225.
-
- 17 Dec, 2014 1 commit
-
-
Rhommel Lamas authored
-
- 16 Dec, 2014 1 commit
-
-
antirez authored
-
- 13 Dec, 2014 2 commits
-
-
antirez authored
Otherwise there are security risks, especially when providing Redis as a service, the user may "sniff" for admin commands renamed to an unguessable string via rename-command in redis.conf.
-
antirez authored
The old list did not made much sense... and the flag is currently not used at all, so no side effects.
-
- 12 Dec, 2014 3 commits
-
-
Salvatore Sanfilippo authored
Adds a symlink for redis-sentinel when Make install
-
antirez authored
It fixes a bad bug that crashes the server in certain conditions as shown in issue #2210.
-
Rhommel Lamas authored
-