- 25 Mar, 2020 4 commits
-
-
antirez authored
-
antirez authored
A very commonly signaled operational problem with Redis master-replicas sets is that, once the master becomes unavailable for some reason, especially because of network problems, many times it wont be able to perform a partial resynchronization with the new master, once it rejoins the partition, for the following reason: 1. The master becomes isolated, however it keeps sending PINGs to the replicas. Such PINGs will never be received since the link connection is actually already severed. 2. On the other side, one of the replicas will turn into the new master, setting its secondary replication ID offset to the one of the last command received from the old master: this offset will not include the PINGs sent by the master once the link was already disconnected. 3. When the master rejoins the partion and is turned into a replica, its offset will be too advanced because of the PINGs, so a PSYNC will fail, and a full synchronization will be required. Related to issue #7002 and other discussion we had in the past around this problem.
-
antirez authored
Related to #7022.
-
Salvatore Sanfilippo authored
MULTI/EXEC during LUA script timeout are messed up
-
- 23 Mar, 2020 13 commits
-
-
Oran Agra authored
Redis refusing to run MULTI or EXEC during script timeout may cause partial transactions to run. 1) if the client sends MULTI+commands+EXEC in pipeline without waiting for response, but these arrive to the shards partially while there's a busy script, and partially after it eventually finishes: we'll end up running only part of the transaction (since multi was ignored, and exec would fail). 2) similar to the above if EXEC arrives during busy script, it'll be ignored and the client state remains in a transaction. the 3rd test which i added for a case where MULTI and EXEC are ok, and only the body arrives during busy script was already handled correctly since processCommand calls flagTransaction
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
-
Salvatore Sanfilippo authored
Added BITFIELD_RO variants for read-only operations.
-
antirez authored
-
Salvatore Sanfilippo authored
Allow RM_GetContextFlags to work with ctx==NULL
-
Salvatore Sanfilippo authored
fix potential memory leak in redis-cli lua debug mode
-
Salvatore Sanfilippo authored
Fix issues with failed/rejected accepts.
-
Salvatore Sanfilippo authored
Fix Bug for Client Side Caching: Unexpected Behaviour when Switching between OPTIN/OPTOUT Mode
-
hwware authored
-
hwware authored
-
- 22 Mar, 2020 3 commits
-
-
Yossi Gottlieb authored
-
Yossi Gottlieb authored
-
Yossi Gottlieb authored
We assume accept handlers may choose to reject a connection and close it, but connAccept() callers can't distinguish between this state and other error states requiring connClose(). This makes it safe (and mandatory!) to always call connClose() if connAccept() fails, and safe for accept handlers to close connections (which will defer).
-
- 20 Mar, 2020 5 commits
-
-
Salvatore Sanfilippo authored
add missing commands description in cluster help
-
hwware authored
-
antirez authored
-
antirez authored
-
antirez authored
This fixes issue #7011.
-
- 18 Mar, 2020 8 commits
-
-
hwware authored
-
Guy Benoish authored
-
Salvatore Sanfilippo authored
Support Redis Cluster Proxy PROXY INFO command
-
Salvatore Sanfilippo authored
Update redis.conf
-
Salvatore Sanfilippo authored
Fix data inconsistency
-
WuYunlong authored
Before this commit, when upgrading a replica, expired keys will not be loaded, thus causing replica having less keys in db. To this point, master and replica's keys is logically consistent. However, before the keys in master and replica are physically consistent, that is, they have the same dbsize, if master got a problem and the replica got promoted and becomes new master of that partition, and master updates a key which does not exist on master, but physically exists on the old master(new replica), the old master would refuse to update the key, thus causing master and replica data inconsistent. How could this happen? That's all because of the wrong judgement of roles while starting up the server. We can not use server.masterhost to judge if the server is master or replica, since it fails in cluster mode. When we start the server, we load rdb and do want to load expired keys, and do not want to have the ability to active expire keys, if it is a replica.
-
WuYunlong authored
-
박승현 authored
-
- 16 Mar, 2020 7 commits