Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
ruanhaishen
Willemt Raft
Commits
285fdffb
Commit
285fdffb
authored
Nov 16, 2015
by
Willem Thiart
Browse files
Server ignores old appendentries response messages
parent
b7543091
Changes
2
Hide whitespace changes
Inline
Side-by-side
src/raft_server.c
View file @
285fdffb
...
@@ -184,13 +184,14 @@ int raft_recv_appendentries_response(raft_server_t* me_,
...
@@ -184,13 +184,14 @@ int raft_recv_appendentries_response(raft_server_t* me_,
raft_become_follower
(
me_
);
raft_become_follower
(
me_
);
return
0
;
return
0
;
}
}
else
if
(
me
->
current_term
!=
r
->
term
)
return
0
;
if
(
0
==
r
->
success
)
if
(
0
==
r
->
success
)
{
{
/* If AppendEntries fails because of log inconsistency:
/* If AppendEntries fails because of log inconsistency:
decrement nextIndex and retry (§5.3) */
decrement nextIndex and retry (§5.3) */
assert
(
0
<=
raft_node_get_next_idx
(
node
));
assert
(
0
<=
raft_node_get_next_idx
(
node
));
// TODO can jump back to where node is different instead of iterating
raft_node_set_next_idx
(
node
,
r
->
current_idx
+
1
);
raft_node_set_next_idx
(
node
,
r
->
current_idx
+
1
);
/* retry */
/* retry */
...
...
tests/test_server.c
View file @
285fdffb
...
@@ -1817,7 +1817,7 @@ void TestRaft_leader_recv_appendentries_response_jumps_to_lower_next_idx(
...
@@ -1817,7 +1817,7 @@ void TestRaft_leader_recv_appendentries_response_jumps_to_lower_next_idx(
/* receive mock success responses */
/* receive mock success responses */
memset
(
&
aer
,
0
,
sizeof
(
msg_appendentries_response_t
));
memset
(
&
aer
,
0
,
sizeof
(
msg_appendentries_response_t
));
aer
.
term
=
1
;
aer
.
term
=
2
;
aer
.
success
=
0
;
aer
.
success
=
0
;
aer
.
current_idx
=
1
;
aer
.
current_idx
=
1
;
raft_recv_appendentries_response
(
r
,
1
,
&
aer
);
raft_recv_appendentries_response
(
r
,
1
,
&
aer
);
...
@@ -2091,6 +2091,37 @@ void TestRaft_leader_recv_appendentries_response_increment_idx_of_node(
...
@@ -2091,6 +2091,37 @@ void TestRaft_leader_recv_appendentries_response_increment_idx_of_node(
CuAssertTrue
(
tc
,
2
==
raft_node_get_next_idx
(
p
));
CuAssertTrue
(
tc
,
2
==
raft_node_get_next_idx
(
p
));
}
}
void
TestRaft_leader_recv_appendentries_response_drop_message_if_term_is_old
(
CuTest
*
tc
)
{
raft_cbs_t
funcs
=
{
.
send_appendentries
=
sender_appendentries
,
.
log
=
NULL
};
void
*
sender
=
sender_new
(
NULL
);
void
*
r
=
raft_new
();
raft_add_node
(
r
,
(
void
*
)
1
,
1
);
raft_add_node
(
r
,
(
void
*
)
2
,
0
);
raft_set_callbacks
(
r
,
&
funcs
,
sender
);
/* I'm the leader */
raft_set_state
(
r
,
RAFT_STATE_LEADER
);
raft_set_current_term
(
r
,
2
);
raft_node_t
*
p
=
raft_get_node
(
r
,
1
);
CuAssertTrue
(
tc
,
1
==
raft_node_get_next_idx
(
p
));
/* receive OLD mock success responses */
msg_appendentries_response_t
aer
;
aer
.
term
=
1
;
aer
.
success
=
1
;
aer
.
current_idx
=
1
;
aer
.
first_idx
=
1
;
raft_recv_appendentries_response
(
r
,
1
,
&
aer
);
CuAssertTrue
(
tc
,
1
==
raft_node_get_next_idx
(
p
));
}
void
TestRaft_leader_recv_appendentries_steps_down_if_newer
(
void
TestRaft_leader_recv_appendentries_steps_down_if_newer
(
CuTest
*
tc
)
CuTest
*
tc
)
{
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment