1. 21 Nov, 2017 8 commits
    • Li Wei's avatar
      DAOS-279 server: Zero timeout_elapsed for leaders · 51e049fd
      Li Wei authored
      
      
      If raft_become_candidate() assigns a negative value e (i.e.,
      -election_timeout < e < 0) to timeout_elapsed, and if this replica
      successfully becomes the leader, then this leader won't send heartbeats
      for request_timeout - e milliseconds. This may be longer than
      election_timeout and cause an unnecessary leadership change.
      
      This patch zeroes timeout_elapsed in raft_become_leader(), randomizes
      election timeouts in [election_timeout, 2 * election_timeout), and fixes
      raft_recv_appendentries() to avoid zeroing timeout_elapsed if the AE
      request has an older term.
      Signed-off-by: default avatarLi Wei <wei.g.li@intel.com>
      51e049fd
    • Li Wei's avatar
      DAOS-279 server: Discard current_leader when term changes · 14a4e6a2
      Li Wei authored
      
      
      When a leader learns of a newer term and steps down, it should discard
      current_leader. Otherwise, a client request may be rejected with
      RAFT_ERR_NOT_LEADER and a hint pointing to this replica itself!
      
      For simplicity, this patche follows the Raft paper to discard
      current_leader whenever current_term changes. And, when receiving an AE
      with an up-to-date term, a server always updates current_leader, as this
      information is absolute, even if the previous entry doesn't match.
      
      This patch also fixes a test that has previously been failing due to
      incorrect node IDs.
      Signed-off-by: default avatarLi Wei <wei.g.li@intel.com>
      14a4e6a2
    • Li Wei's avatar
      DAOS-333 log: Pass correct indices to log_offer and log_poll · 3096ecd7
      Li Wei authored
      
      
      log_offer and log_poll should get log entry index rather than internal
      array index. That would match the callback comment in raft.h and would
      also match the log_pop case.
      Signed-off-by: default avatarLi Wei <wei.g.li@intel.com>
      3096ecd7
    • Li Wei's avatar
      DAOS-333 server: Persist term and vote atomically · 854a06d2
      Li Wei authored
      
      
      Remind users' persist_term implementations to persist currentTerm and
      nil votedFor atomically.
      Signed-off-by: default avatarLi Wei <wei.g.li@intel.com>
      854a06d2
    • Li Wei's avatar
      DAOS-333 server: Remove unnecessary index check for AE requests · 5bad59c1
      Li Wei authored
      
      
      raft_recv_appendentries() doesn't need to check prev_log_idx against
      currentIndex, as this is already done implicitly by getting the entry at
      prev_log_idx.
      Signed-off-by: default avatarLi Wei <wei.g.li@intel.com>
      5bad59c1
    • Li Wei's avatar
      DAOS-333 server: Check AE reply term first · 8b444aa1
      Li Wei authored
      
      
      raft_recv_appendentries_response() should check r->term before checking
      r->current_idx.
      Signed-off-by: default avatarLi Wei <wei.g.li@intel.com>
      8b444aa1
    • Li Wei's avatar
      DAOS-333 server: Handle memory allocation errors · 6bf3f5f1
      Li Wei authored
      
      
      Check and handle memory allocation errors by reporting them back to
      users via NULL or RAFT_ERR_NOMEM return values.
      Signed-off-by: default avatarLi Wei <wei.g.li@intel.com>
      6bf3f5f1
    • Li Wei's avatar
      DAOS-279 log: Avoid changing caller input entry · 920d574a
      Li Wei authored
      
      
      log_append_entry() passes caller's raft_entry_t to log_offer. If the
      log_offer implementation sets the data buffer to different value,
      caller's raft_entry_t gets modified as a side effect. This is
      error-prone as callers are usually responsible for freeing the data
      buffer with such a log_offer implementation. This patch passes the
      raft_entry_t in the log to log_offer instead. Also, ety in
      raft_recv_entry() is no longer required.
      Signed-off-by: default avatarLi Wei <wei.g.li@intel.com>
      920d574a
  2. 20 Nov, 2017 4 commits
  3. 22 Jun, 2017 1 commit
  4. 21 Jun, 2017 2 commits
    • Willem Thiart's avatar
      Fixes #41 · 9651a97f
      Willem Thiart authored
      Second if statement was redundant.
      9651a97f
    • Willem Thiart's avatar
      Fixes #40 · 883d0d24
      Willem Thiart authored
      raft_send_requestvote and raft_send_appendentries now return proper
      error codes.
      883d0d24
  5. 20 Jun, 2017 1 commit
    • Willem Thiart's avatar
      Fixes #37 · 3e011ae2
      Willem Thiart authored
      Avoid deleting logs because of out-of-order/quick heartbeats.
      3e011ae2
  6. 30 May, 2017 1 commit
  7. 24 May, 2017 1 commit
    • Willem Thiart's avatar
      Fixes #35 · 9bdf41b5
      Willem Thiart authored
      Avoid for loop to increase performance when tallying votes for
      committing.
      9bdf41b5
  8. 09 May, 2017 1 commit
    • Willem Thiart's avatar
      Change: code now assumes callbacks are provided · c3443aac
      Willem Thiart authored
      Beforehand there were if statements to check if callbacks were provided
      by the user. This was only useful for making the test suites shorter.
      These if statements have been removed so that the core code is more
      concise.
      c3443aac
  9. 25 Oct, 2016 2 commits
  10. 20 Oct, 2016 1 commit
  11. 20 Sep, 2016 1 commit
  12. 10 Sep, 2016 1 commit
  13. 31 Aug, 2016 1 commit
  14. 28 Aug, 2016 1 commit
  15. 11 Jun, 2016 9 commits
  16. 22 May, 2016 2 commits
  17. 20 May, 2016 2 commits
  18. 19 May, 2016 1 commit