1. 13 Jun, 2018 2 commits
  2. 11 Jun, 2018 5 commits
  3. 08 Jun, 2018 1 commit
  4. 07 Jun, 2018 2 commits
    • Willem Thiart's avatar
      Remove RAFT_LOGTYPE_SNAPSHOT · 700eebe6
      Willem Thiart authored
      The RAFT_LOGTYPE_SNAPSHOT was a bad design choice. It's better to not
      have this marker entry so that users don't have to check for the log
      entry type in the callbacks. Also, loading a snapshot correctly created
      this marker entry, but the compaction side did not. It's better to
      remove this log type than to fix this asymmetry.
      
      Fixes the following edge cases:
      - Server crashes if the last snapshot index is N and a appendentries
      message pops entries all the way back to index N.
      - Server sends an appendentries message with an invalid prev_log_idx and
      prev_log_term, causing the peer to crash.
      700eebe6
    • Yossi Gottlieb's avatar
      Off by one fixes (#65) · 9de8af47
      Yossi Gottlieb authored
      * Fix off-by-one in apply_log idx.
      
      * Fix log_get_from_idx() off by one error.
      9de8af47
  5. 23 May, 2018 2 commits
  6. 17 May, 2018 4 commits
  7. 16 May, 2018 7 commits
  8. 09 Jan, 2018 2 commits
  9. 08 Jan, 2018 4 commits
  10. 29 Dec, 2017 2 commits
  11. 21 Nov, 2017 9 commits
    • Willem Thiart's avatar
      Add make infer · f0a22790
      Willem Thiart authored
      f0a22790
    • Li Wei's avatar
      DAOS-333 include: Export raft_become_follower() · a7a8291e
      Li Wei authored
      
      
      Move the declaration of raft_become_follower() from raft_private.h to
      raft.h, so that users may voluntarily give up leadership.
      Signed-off-by: default avatarLi Wei <wei.g.li@intel.com>
      a7a8291e
    • Li Wei's avatar
      DAOS-333 server: Handle storage access errors · 76d56d0c
      Li Wei authored
      
      
      User storage callbacks may return negative errors smaller than
      RAFT_ERR_LAST. These will be returned all the way to the API methods,
      which report the errors back to users, so that appropriate handlings may
      be performed.
      Signed-off-by: default avatarLi Wei <wei.g.li@intel.com>
      76d56d0c
    • Li Wei's avatar
      DAOS-333 server: Don't remove later entries for matching AEs · 77fb6117
      Li Wei authored
      
      
      If an AE request's previous entry matches the follower's, then the
      follower doesn't need to truncate its log at prev_log_idx. When the
      follower checks if the other entries in the AE request are consistent
      with its local ones, it already takes care of truncating at any
      inconsistency. If any later entries not covered by this AE request are
      inconsistent, future AE requests shall truncate them.
      Signed-off-by: default avatarLi Wei <wei.g.li@intel.com>
      77fb6117
    • Li Wei's avatar
      Revert "Change: code now assumes callbacks are provided" · e33da84a
      Li Wei authored
      This reverts commit c3443aac. Test
      changes are left intact.
      e33da84a
    • Li Wei's avatar
      DAOS-279 server: Zero timeout_elapsed for leaders · 51e049fd
      Li Wei authored
      
      
      If raft_become_candidate() assigns a negative value e (i.e.,
      -election_timeout < e < 0) to timeout_elapsed, and if this replica
      successfully becomes the leader, then this leader won't send heartbeats
      for request_timeout - e milliseconds. This may be longer than
      election_timeout and cause an unnecessary leadership change.
      
      This patch zeroes timeout_elapsed in raft_become_leader(), randomizes
      election timeouts in [election_timeout, 2 * election_timeout), and fixes
      raft_recv_appendentries() to avoid zeroing timeout_elapsed if the AE
      request has an older term.
      Signed-off-by: default avatarLi Wei <wei.g.li@intel.com>
      51e049fd
    • Li Wei's avatar
      DAOS-279 server: Discard current_leader when term changes · 14a4e6a2
      Li Wei authored
      
      
      When a leader learns of a newer term and steps down, it should discard
      current_leader. Otherwise, a client request may be rejected with
      RAFT_ERR_NOT_LEADER and a hint pointing to this replica itself!
      
      For simplicity, this patche follows the Raft paper to discard
      current_leader whenever current_term changes. And, when receiving an AE
      with an up-to-date term, a server always updates current_leader, as this
      information is absolute, even if the previous entry doesn't match.
      
      This patch also fixes a test that has previously been failing due to
      incorrect node IDs.
      Signed-off-by: default avatarLi Wei <wei.g.li@intel.com>
      14a4e6a2
    • Li Wei's avatar
      DAOS-333 log: Pass correct indices to log_offer and log_poll · 3096ecd7
      Li Wei authored
      
      
      log_offer and log_poll should get log entry index rather than internal
      array index. That would match the callback comment in raft.h and would
      also match the log_pop case.
      Signed-off-by: default avatarLi Wei <wei.g.li@intel.com>
      3096ecd7
    • Li Wei's avatar
      DAOS-333 server: Persist term and vote atomically · 854a06d2
      Li Wei authored
      
      
      Remind users' persist_term implementations to persist currentTerm and
      nil votedFor atomically.
      Signed-off-by: default avatarLi Wei <wei.g.li@intel.com>
      854a06d2