Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
ruanhaishen
RedisLabs Raft
Commits
5614926e
Unverified
Commit
5614926e
authored
Mar 13, 2022
by
Ozan Tezcan
Committed by
GitHub
Mar 13, 2022
Browse files
Enabled compiler warnings: -Wall -Wextra -pedantic (#87)
Enabled compiler warnings and fixed issues
parent
23ffe611
Changes
5
Hide whitespace changes
Inline
Side-by-side
CMakeLists.txt
View file @
5614926e
...
...
@@ -107,13 +107,13 @@ set(RAFT_SOURCE_FILES
src/raft_server_properties.c
)
add_library
(
raft STATIC
${
RAFT_SOURCE_FILES
}
)
target_compile_options
(
raft PRIVATE -g
)
target_compile_options
(
raft PRIVATE -g
-Wall -Wextra -pedantic
)
target_include_directories
(
raft PRIVATE include
)
add_library
(
raft_shared SHARED
${
RAFT_SOURCE_FILES
}
)
target_include_directories
(
raft_shared PRIVATE include
)
set_property
(
TARGET raft_shared PROPERTY POSITION_INDEPENDENT_CODE ON
)
target_compile_options
(
raft PRIVATE -g
)
target_compile_options
(
raft
_shared
PRIVATE -g
-Wall -Wextra -pedantic
)
define_test
(
test_log
)
define_test
(
test_log_impl
)
...
...
Makefile
View file @
5614926e
...
...
@@ -7,9 +7,7 @@ LIB = -I libs
INC
=
-I
include
GCOV_CFLAGS
=
-fprofile-arcs
-ftest-coverage
SHELL
=
/bin/bash
CFLAGS
+=
-Iinclude
-Werror
-Werror
=
return
-type
-Werror
=
uninitialized
-Wcast-align
\
-Wno-pointer-sign
-fno-omit-frame-pointer
-fno-common
-fsigned-char
\
-Wunused-variable
-g
-O2
-fPIC
CFLAGS
+=
-Iinclude
-fno-omit-frame-pointer
-fno-common
-fsigned-char
-g
-O2
-fPIC
ifeq
($(COVERAGE), 1)
CFLAGS
+=
$(GCOV_CFLAGS)
TEST_CFLAGS
=
$(CFLAGS)
...
...
@@ -17,6 +15,8 @@ else
TEST_CFLAGS
=
$(CFLAGS)
$(GCOV_CFLAGS)
endif
LIB_CFLAGS
=
$(CFLAGS)
-Wextra
-Wall
-pedantic
-Werror
UNAME
:=
$(
shell
uname
)
ifeq
($(UNAME), Darwin)
...
...
@@ -62,7 +62,7 @@ shared: $(LIBRAFT_SHARED)
static
:
$(LIBRAFT_STATIC)
$(LIBRAFT_SHARED)
:
$(OBJECTS)
$(CC)
$^
$(LDFLAGS)
$(CFLAGS)
-fPIC
$(SHAREDFLAGS)
-o
$@
$(CC)
$^
$(LDFLAGS)
$(
LIB_
CFLAGS)
-fPIC
$(SHAREDFLAGS)
-o
$@
$(LIBRAFT_STATIC)
:
$(OBJECTS)
ar
-r
$@
$^
...
...
@@ -86,7 +86,7 @@ $(TEST_DIR)/%.o: $(TEST_DIR)/%.c
$(CC)
$(TEST_CFLAGS)
$(INC)
-c
-o
$@
$<
$(BUILD_DIR)/%.o
:
$(SRC_DIR)/%.c
$(CC)
$(CFLAGS)
$(INC)
-c
-o
$@
$<
$(CC)
$(
LIB_
CFLAGS)
$(INC)
-c
-o
$@
$<
.PHONY
:
test_helper
test_helper
:
$(TEST_HELPERS)
...
...
include/raft.h
View file @
5614926e
...
...
@@ -113,7 +113,7 @@ typedef struct raft_entry
unsigned
int
data_len
;
/** data */
char
data
[
0
];
char
data
[];
}
raft_entry_t
;
/** Message sent from client to server.
...
...
src/raft_log.c
View file @
5614926e
...
...
@@ -76,6 +76,7 @@ static int __ensurecapacity(log_private_t * me)
int
log_load_from_snapshot
(
log_t
*
me_
,
raft_index_t
idx
,
raft_term_t
term
)
{
(
void
)
term
;
log_private_t
*
me
=
(
log_private_t
*
)
me_
;
log_clear_entries
(
me_
);
...
...
@@ -351,6 +352,8 @@ static void __log_free(void *log)
static
void
__log_reset
(
void
*
log
,
raft_index_t
first_idx
,
raft_term_t
term
)
{
(
void
)
term
;
log_clear_entries
(
log
);
log_clear
(
log
);
...
...
@@ -426,6 +429,7 @@ static raft_index_t __log_count(void *log)
static
int
__log_sync
(
void
*
log
)
{
(
void
)
log
;
return
0
;
}
...
...
src/raft_server.c
View file @
5614926e
...
...
@@ -264,7 +264,10 @@ void raft_remove_node(raft_server_t* me_, raft_node_t* node)
break
;
}
}
assert
(
found
);
(
void
)
found
;
memmove
(
&
me
->
nodes
[
i
],
&
me
->
nodes
[
i
+
1
],
sizeof
(
*
me
->
nodes
)
*
(
me
->
num_nodes
-
i
-
1
));
me
->
num_nodes
--
;
...
...
@@ -967,6 +970,7 @@ int raft_recv_requestvote(raft_server_t* me_,
msg_requestvote_t
*
vr
,
msg_requestvote_response_t
*
r
)
{
(
void
)
node
;
raft_server_private_t
*
me
=
(
raft_server_private_t
*
)
me_
;
int
e
=
0
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment