Unverified Commit 5614926e authored by Ozan Tezcan's avatar Ozan Tezcan Committed by GitHub
Browse files

Enabled compiler warnings: -Wall -Wextra -pedantic (#87)

Enabled compiler warnings and fixed issues
parent 23ffe611
...@@ -107,13 +107,13 @@ set(RAFT_SOURCE_FILES ...@@ -107,13 +107,13 @@ set(RAFT_SOURCE_FILES
src/raft_server_properties.c) src/raft_server_properties.c)
add_library(raft STATIC ${RAFT_SOURCE_FILES}) add_library(raft STATIC ${RAFT_SOURCE_FILES})
target_compile_options(raft PRIVATE -g) target_compile_options(raft PRIVATE -g -Wall -Wextra -pedantic)
target_include_directories(raft PRIVATE include) target_include_directories(raft PRIVATE include)
add_library(raft_shared SHARED ${RAFT_SOURCE_FILES}) add_library(raft_shared SHARED ${RAFT_SOURCE_FILES})
target_include_directories(raft_shared PRIVATE include) target_include_directories(raft_shared PRIVATE include)
set_property(TARGET raft_shared PROPERTY POSITION_INDEPENDENT_CODE ON) set_property(TARGET raft_shared PROPERTY POSITION_INDEPENDENT_CODE ON)
target_compile_options(raft PRIVATE -g) target_compile_options(raft_shared PRIVATE -g -Wall -Wextra -pedantic)
define_test(test_log) define_test(test_log)
define_test(test_log_impl) define_test(test_log_impl)
......
...@@ -7,9 +7,7 @@ LIB = -I libs ...@@ -7,9 +7,7 @@ LIB = -I libs
INC = -I include INC = -I include
GCOV_CFLAGS = -fprofile-arcs -ftest-coverage GCOV_CFLAGS = -fprofile-arcs -ftest-coverage
SHELL = /bin/bash SHELL = /bin/bash
CFLAGS += -Iinclude -Werror -Werror=return-type -Werror=uninitialized -Wcast-align \ CFLAGS += -Iinclude -fno-omit-frame-pointer -fno-common -fsigned-char -g -O2 -fPIC
-Wno-pointer-sign -fno-omit-frame-pointer -fno-common -fsigned-char \
-Wunused-variable -g -O2 -fPIC
ifeq ($(COVERAGE), 1) ifeq ($(COVERAGE), 1)
CFLAGS += $(GCOV_CFLAGS) CFLAGS += $(GCOV_CFLAGS)
TEST_CFLAGS = $(CFLAGS) TEST_CFLAGS = $(CFLAGS)
...@@ -17,6 +15,8 @@ else ...@@ -17,6 +15,8 @@ else
TEST_CFLAGS = $(CFLAGS) $(GCOV_CFLAGS) TEST_CFLAGS = $(CFLAGS) $(GCOV_CFLAGS)
endif endif
LIB_CFLAGS = $(CFLAGS) -Wextra -Wall -pedantic -Werror
UNAME := $(shell uname) UNAME := $(shell uname)
ifeq ($(UNAME), Darwin) ifeq ($(UNAME), Darwin)
...@@ -62,7 +62,7 @@ shared: $(LIBRAFT_SHARED) ...@@ -62,7 +62,7 @@ shared: $(LIBRAFT_SHARED)
static: $(LIBRAFT_STATIC) static: $(LIBRAFT_STATIC)
$(LIBRAFT_SHARED): $(OBJECTS) $(LIBRAFT_SHARED): $(OBJECTS)
$(CC) $^ $(LDFLAGS) $(CFLAGS) -fPIC $(SHAREDFLAGS) -o $@ $(CC) $^ $(LDFLAGS) $(LIB_CFLAGS) -fPIC $(SHAREDFLAGS) -o $@
$(LIBRAFT_STATIC): $(OBJECTS) $(LIBRAFT_STATIC): $(OBJECTS)
ar -r $@ $^ ar -r $@ $^
...@@ -86,7 +86,7 @@ $(TEST_DIR)/%.o: $(TEST_DIR)/%.c ...@@ -86,7 +86,7 @@ $(TEST_DIR)/%.o: $(TEST_DIR)/%.c
$(CC) $(TEST_CFLAGS) $(INC) -c -o $@ $< $(CC) $(TEST_CFLAGS) $(INC) -c -o $@ $<
$(BUILD_DIR)/%.o: $(SRC_DIR)/%.c $(BUILD_DIR)/%.o: $(SRC_DIR)/%.c
$(CC) $(CFLAGS) $(INC) -c -o $@ $< $(CC) $(LIB_CFLAGS) $(INC) -c -o $@ $<
.PHONY: test_helper .PHONY: test_helper
test_helper: $(TEST_HELPERS) test_helper: $(TEST_HELPERS)
......
...@@ -113,7 +113,7 @@ typedef struct raft_entry ...@@ -113,7 +113,7 @@ typedef struct raft_entry
unsigned int data_len; unsigned int data_len;
/** data */ /** data */
char data[0]; char data[];
} raft_entry_t; } raft_entry_t;
/** Message sent from client to server. /** Message sent from client to server.
......
...@@ -76,6 +76,7 @@ static int __ensurecapacity(log_private_t * me) ...@@ -76,6 +76,7 @@ static int __ensurecapacity(log_private_t * me)
int log_load_from_snapshot(log_t *me_, raft_index_t idx, raft_term_t term) int log_load_from_snapshot(log_t *me_, raft_index_t idx, raft_term_t term)
{ {
(void) term;
log_private_t* me = (log_private_t*)me_; log_private_t* me = (log_private_t*)me_;
log_clear_entries(me_); log_clear_entries(me_);
...@@ -351,6 +352,8 @@ static void __log_free(void *log) ...@@ -351,6 +352,8 @@ static void __log_free(void *log)
static void __log_reset(void *log, raft_index_t first_idx, raft_term_t term) static void __log_reset(void *log, raft_index_t first_idx, raft_term_t term)
{ {
(void) term;
log_clear_entries(log); log_clear_entries(log);
log_clear(log); log_clear(log);
...@@ -426,6 +429,7 @@ static raft_index_t __log_count(void *log) ...@@ -426,6 +429,7 @@ static raft_index_t __log_count(void *log)
static int __log_sync(void *log) static int __log_sync(void *log)
{ {
(void) log;
return 0; return 0;
} }
......
...@@ -264,7 +264,10 @@ void raft_remove_node(raft_server_t* me_, raft_node_t* node) ...@@ -264,7 +264,10 @@ void raft_remove_node(raft_server_t* me_, raft_node_t* node)
break; break;
} }
} }
assert(found); assert(found);
(void) found;
memmove(&me->nodes[i], &me->nodes[i + 1], sizeof(*me->nodes) * (me->num_nodes - i - 1)); memmove(&me->nodes[i], &me->nodes[i + 1], sizeof(*me->nodes) * (me->num_nodes - i - 1));
me->num_nodes--; me->num_nodes--;
...@@ -967,6 +970,7 @@ int raft_recv_requestvote(raft_server_t* me_, ...@@ -967,6 +970,7 @@ int raft_recv_requestvote(raft_server_t* me_,
msg_requestvote_t* vr, msg_requestvote_t* vr,
msg_requestvote_response_t *r) msg_requestvote_response_t *r)
{ {
(void) node;
raft_server_private_t* me = (raft_server_private_t*)me_; raft_server_private_t* me = (raft_server_private_t*)me_;
int e = 0; int e = 0;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment