- 20 Feb, 2019 1 commit
-
-
Mark Nunberg authored
-
- 24 Oct, 2018 1 commit
-
-
Stefan Hacker authored
Referred to redisContextReadReply which I cannot find in this codebase nor the old redis-tools one. Presumably this meant to say redisGetReplyFromReader which is how redisBufferRead is used in this file. Could've also meant the interface function redisReaderGetReply.
-
- 26 Sep, 2018 1 commit
-
-
Mark Nunberg authored
This retrieves the actual error which occurred, as getsockopt is not always reliable in this regard.
-
- 01 May, 2018 3 commits
-
-
Justin Brewer authored
free(NULL) is a valid NOP. Most of the hiredis free functions behave the same way. redisReaderFree is updated to also be NULL-safe. There is one redundant NULL check at sds.c:1036, but it's left as is since sds is imported from upstream. Signed-off-by:
Justin Brewer <jzb0012@auburn.edu>
-
Justin Brewer authored
calloc is guaranteed to provide a zero-initialized buffer. There is no need to set fields to zero explicitly. Signed-off-by:
Justin Brewer <jzb0012@auburn.edu>
-
Justin Brewer authored
Since _GNU_SOURCE is now guaranteed to be unset, it is no longer necessary to support the GNU-specific version of strerror_r. Drop __redis_strerror_r from the header, and call strerror_r directly. This breaks any external users of this macro, but they shouldn't have been using it in the first place. Signed-off-by:
Justin Brewer <jzb0012@auburn.edu>
-
- 05 Jan, 2018 1 commit
-
-
cdliuqiang@gmail.com authored
-
- 15 Jun, 2017 1 commit
-
-
amallia authored
-
- 13 May, 2016 1 commit
-
-
Paulino Huerta authored
this issue is very significant, because not allow the proper execution of the "function redisCommandArgv". The server returns "invalid bulk length". Thanks!
-
- 27 Oct, 2015 1 commit
-
-
charsyam authored
-
- 14 Sep, 2015 1 commit
-
-
Jan-Erik Rediger authored
This reverts commit 1db17f25. If the `REDIS_CONNECTED` flag is cleared, the async onDisconnect callback function will never be called. This causes problems as the disconnect is never reported back to the user. Closes #359
-
- 24 Aug, 2015 1 commit
-
-
Jerry Jacobs authored
-
- 30 Apr, 2015 1 commit
-
-
Alex Balashov authored
Renamed redisContext struct member 'unix' to 'unix_sock' to avoid encountering defined constant 'unix' in GNU C environment (see commit d8145d79). Not all code using hiredis can compile using '-std=c99', and/or not all users are able to easily make that change to the build process of various open-source projects, so it is more pragmatic to choose a different identifier that does not impose this requirement.
-
- 16 Apr, 2015 2 commits
-
-
Jan-Erik Rediger authored
-
Jan-Erik Rediger authored
Originally implemented by @abedra as part of #306. In case a write or read times out, we force an error state, because we can't guarantuee that the next read will get the right data. Instead we need to reconnect to have a clean-state connection, which is now easily possible with this method.
-
- 22 Jan, 2015 1 commit
-
-
Matt Stancliff authored
This replaces the old intlen() implementation with a slightly faster way of counting digits. Implementation taken from the same place where digits10() in redis/src/util.c came from. The old 'intlen' allowed negative inputs, but no usage in hiredis was passing negative numbers, so that ability is removed. Also, the new implementation can count higher (uint64_t) instead of limited to just int as before. Fixes #295 by replacing implementation
-
- 05 Jan, 2015 12 commits
-
-
Matt Stancliff authored
-
Matt Stancliff authored
The strerror_r API has two flavors depending on system options. The bad flavor uses a static buffer for returning results, so if you save the pointer from strerror_r, the string you're referencing becomes useless if anybody else calls strerror_r again The good flavor does what you expect: it writes the error to your buffer. This commit uses strerror_r directly if it's a good version or copies the static buffer into our private buffer if it's a bad version. Thanks to gemorin for explaining the problem and drafting a fix. Fixes #239
-
tzickel authored
Makes hiredis reading functions easier to include in external projects [fixed all merge conflicts against current version] Closes #249
-
Matt Stancliff authored
Previously, redisvAppendCommand() would return OOM even with formatting errors. Now we use OTHER with an error string telling the user the error was formatting related, not memory related. This also fixes a potentially worse bug where were would pass error result of -1 as an actual length to another function taking an unsigned length, which would result in crash/overallocation/errors. Now for that case, we just return an error immediately and stop processing the command. Fixes #177
-
NanXiao authored
If realloc fails, the curargv will be NULL. Closes #253
-
NanXiao authored
Check whether the obuf or reader is empty: if one of the items is empty, free the redisContext.
-
Nan Xiao authored
Flags can occur in any order in format string, so we can't assume any order. In original code, the redisvFormatCommand can process " %#+d" correctly, but can't process "%+#d". Closes #257
-
Matt Stancliff authored
External callers may not know about sdsfree, so let's give them an easy way to know how to free their sds result.
-
Mareq authored
[Cleaned up: - name of function: freeRedis... -> redisFree... - return value of function (free doesn't return anything) - parameter type for function. - we don't need to free a char**, the char** is just for returning from the assignment functoin.] Closes #250
-
mike authored
[This introduces some new API functions.] * Adds new flag to the connection context indicating SO_REUSEADDR should be set. * Adds max number of retries constant for when connect() hits EADDRNOTAVAIL. * Adds new function, redisAsyncConnectBindWithReuse(), letting clients enable this functionality. [Removed trailing whitespace in new header lines.] Closes #264
-
jinguoli authored
[It doesn't _actually_ matter, but technically the order argument is: (number of items, size of items)] Closes #279
-
michael-grunder authored
OK, perhaps the second time is a charm. I forgot that I had hiredis forked from a long time ago, so the initial pull request was hosed. :) * Pulled in sdscatfmt() from Redis, and modified it to accept a size_t (%T) style format specifier. * Pulled in sdsll2str() and sdsull2str() from Redis (needed by sdscatfmt). * Added a new method, redisFormatSdsCommandArgv() which takes and sds* as the target, rather than char* (and uses sdscatfmt instead of sprintf for the construction). I get roughly the following improvement: Old: 1.044806 New: 0.481620 The benchmark code itself can be found here: https://gist.github.com/michael-grunder/c92ef31bb632b3d0ad81 Closes #260
-
- 29 May, 2014 1 commit
-
-
Daniel Melani authored
Make redisFree() and freeReplyObject() less surprising by behaving just like free(). That is, don't crash when passing in NULL.
-
- 10 Apr, 2014 1 commit
-
-
Pieter Noordhuis authored
-
- 09 Apr, 2014 3 commits
-
-
antirez authored
SDS is now broken out of Redis into its own project, so include the latest version from the SDS repo. This is a backport of the Redis commit doing the same to the bundled hiredis: https://github.com/antirez/redis/commit/320fa02b9b48ee1c63d88db6344fc0d328e24853
-
Axel Etcheverry authored
Closes #202
-
Eddy Jansson authored
These allows for easier integration of hiredis with external code that wants to manage its fds, say for instance in a pool. Closes #223
-
- 08 Apr, 2014 1 commit
-
-
Matt Stancliff authored
Some environments require binding to specific source addresses instead of letting the system determine which IP a connection should originate from. Closes #233
-
- 11 Jul, 2013 3 commits
-
-
Noah Williamsson authored
The struct timeval argument in redisConnectWithTimeout(), redisConnectUnixWithTimeout(), redisSetTimeout(), redisContextSetTimeout(), redisContextConnectTcp() and redisContextConnectUnix() is never modified and can therefore be marked as const. Signed-off-by:
Noah Williamsson <noah.williamsson@gmail.com>
-
Pieter Noordhuis authored
-
Wolfgang Richter authored
Closes #121.
-
- 29 Apr, 2013 1 commit
-
-
Allen.Dou authored
Make Connection KeepAlive being optional instead of default.
-
- 22 Jan, 2013 1 commit
-
-
Henri Doreau authored
Updated documentation and examples accordingly.
-
- 12 Nov, 2012 1 commit
-
-
Nathan McSween authored
-