1. 16 Apr, 2015 1 commit
    • Jan-Erik Rediger's avatar
      Implement a reconnect method for the client context · d9e0b0f6
      Jan-Erik Rediger authored
      Originally implemented by @abedra as part of #306.
      
      In case a write or read times out, we force an error state, because we
      can't guarantuee that the next read will get the right data.
      Instead we need to reconnect to have a clean-state connection, which is
      now easily possible with this method.
      d9e0b0f6
  2. 22 Jan, 2015 1 commit
    • Matt Stancliff's avatar
      Improve digit counting for multibulk creation · 195aca34
      Matt Stancliff authored
      This replaces the old intlen() implementation with a slightly
      faster way of counting digits.
      
      Implementation taken from the same place where digits10() in
      redis/src/util.c came from.
      
      The old 'intlen' allowed negative inputs, but no usage in hiredis
      was passing negative numbers, so that ability is removed.  Also,
      the new implementation can count higher (uint64_t) instead of
      limited to just int as before.
      
      Fixes #295 by replacing implementation
      195aca34
  3. 05 Jan, 2015 12 commits
    • Matt Stancliff's avatar
      Cleanup tabs and end of line whitespace · f28872ca
      Matt Stancliff authored
      f28872ca
    • Matt Stancliff's avatar
      Fix errno error buffers to not clobber errors · cc202324
      Matt Stancliff authored
      The strerror_r API has two flavors depending on system options.
      
      The bad flavor uses a static buffer for returning results, so if
      you save the pointer from strerror_r, the string you're referencing
      becomes useless if anybody else calls strerror_r again
      
      The good flavor does what you expect: it writes the error to your buffer.
      
      This commit uses strerror_r directly if it's a good version or copies
      the static buffer into our private buffer if it's a bad version.
      
      Thanks to gemorin for explaining the problem and drafting a fix.
      
      Fixes #239
      cc202324
    • tzickel's avatar
      Refactor reading code into read.c · ba3e74c4
      tzickel authored
      Makes hiredis reading functions easier to include in external projects
      
      [fixed all merge conflicts against current version]
      
      Closes #249
      ba3e74c4
    • Matt Stancliff's avatar
      Fix redisAppendCommand error result · 6a00a464
      Matt Stancliff authored
      Previously, redisvAppendCommand() would return OOM even with formatting
      errors.  Now we use OTHER with an error string telling the user the
      error was formatting related, not memory related.
      
      This also fixes a potentially worse bug where were would pass error result
      of -1 as an actual length to another function taking an unsigned length,
      which would result in crash/overallocation/errors.  Now for that case,
      we just return an error immediately and stop processing the command.
      
      Fixes #177
      6a00a464
    • NanXiao's avatar
      Add empty pointer check in error cleanup · e30c96eb
      NanXiao authored
      If realloc fails, the curargv will be NULL.
      
      Closes #253
      e30c96eb
    • NanXiao's avatar
      Add error check in redisContextInit · d1e820d8
      NanXiao authored
      Check whether the obuf or reader is empty: if one of the items is empty,
      free the redisContext.
      d1e820d8
    • Nan Xiao's avatar
      Fix redisvFormatCommand format parsing · b6a86079
      Nan Xiao authored
      Flags can occur in any order in format string, so we can't assume any order.
      
      In original code, the redisvFormatCommand can process " %#+d" correctly,
      but can't process "%+#d".
      
      Closes #257
      b6a86079
    • Matt Stancliff's avatar
      Add API to free hiredis (sds) formattings · 9a753b42
      Matt Stancliff authored
      External callers may not know about sdsfree, so let's
      give them an easy way to know how to free their sds result.
      9a753b42
    • Mareq's avatar
      Add API to free hiredis (char *) formattings · 1b392eb7
      Mareq authored
      [Cleaned up:
        - name of function: freeRedis... -> redisFree...
        - return value of function (free doesn't return anything)
        - parameter type for function.
          - we don't need to free a char**, the char** is just
          for returning from the assignment functoin.]
      
      Closes #250
      1b392eb7
    • mike's avatar
      Add support for SO_REUSEADDR · 7c4d2557
      mike authored
      [This introduces some new API functions.]
      
      * Adds new flag to the connection context indicating SO_REUSEADDR
        should be set.
      * Adds max number of retries constant for when connect() hits
        EADDRNOTAVAIL.
      * Adds new function, redisAsyncConnectBindWithReuse(), letting
        clients enable this functionality.
      
      [Removed trailing whitespace in new header lines.]
      
      Closes #264
      7c4d2557
    • jinguoli's avatar
      Improve calloc() correctness · a1bc89b2
      jinguoli authored
      [It doesn't _actually_ matter, but technically
      the order argument is: (number of items, size of items)]
      
      Closes #279
      a1bc89b2
    • michael-grunder's avatar
      Improve redisAppendCommandArgv performance · 40f7035b
      michael-grunder authored
      OK, perhaps the second time is a charm.  I forgot that I had
      hiredis forked from a long time ago, so the initial pull
      request was hosed.  :)
      
      * Pulled in sdscatfmt() from Redis, and modified it to accept a
        size_t (%T) style format specifier.
      
      * Pulled in sdsll2str() and sdsull2str() from Redis (needed by
        sdscatfmt).
      
      * Added a new method, redisFormatSdsCommandArgv() which takes
        and sds* as the target, rather than char* (and uses sdscatfmt
        instead of sprintf for the construction).
      
      I get roughly the following improvement:
      
      Old: 1.044806
      New: 0.481620
      
      The benchmark code itself can be found here:
      https://gist.github.com/michael-grunder/c92ef31bb632b3d0ad81
      
      Closes #260
      40f7035b
  4. 29 May, 2014 1 commit
    • Daniel Melani's avatar
      Less surprising behaviour. · 05b85ebe
      Daniel Melani authored
      Make redisFree() and freeReplyObject() less surprising by behaving just
      like free(). That is, don't crash when passing in NULL.
      05b85ebe
  5. 10 Apr, 2014 1 commit
  6. 09 Apr, 2014 3 commits
  7. 08 Apr, 2014 1 commit
  8. 11 Jul, 2013 3 commits
  9. 29 Apr, 2013 1 commit
  10. 22 Jan, 2013 1 commit
  11. 12 Nov, 2012 1 commit
  12. 06 Nov, 2012 1 commit
  13. 21 Aug, 2012 3 commits
    • antirez's avatar
      On stack buffer to read replies set to 16k (was 2k). · f7f022e4
      antirez authored
      It was verified experimentally that this value, on Linux kernels, provides
      better performances compared to the 2k value. However larger values
      apparently don't produce any noticeable effect on performances.
      f7f022e4
    • antirez's avatar
      Max depth of multi-bulk reply moved from 2 to 7. · 51ab89d8
      antirez authored
      Hiredis can handle multi bulk replies with a fixed (hardcoded) level of
      nesting. This should be changed in the future in order to avoid
      hardcoded limits. As a quick fix this commit moves the max nesting from 2
      to 7, so that there are no problems when processing replies from the SLOWLOG
      command, from Redis Sentinel, or generated by Redis Lua Scripts (that are
      allowed to generate replies with any level of nesting).
      51ab89d8
    • antirez's avatar
      Configurable reader max idle buffer size. · 7f095053
      antirez authored
      Hiredis used to free unused redisReader buffers bigger than 16k. Now
      this limit is configurable (see the documentation updated by this commit)
      in order to allow working with big payloads without incurring to speed
      penalty.
      7f095053
  14. 20 Dec, 2011 1 commit
  15. 02 Dec, 2011 1 commit
  16. 28 Nov, 2011 1 commit
  17. 09 Jul, 2011 2 commits
  18. 19 Jun, 2011 1 commit
  19. 09 Jun, 2011 1 commit
  20. 05 May, 2011 1 commit
    • Pieter Noordhuis's avatar
      Add function to retrieve formatted reply · 77540aa3
      Pieter Noordhuis authored
      This is done by only truncating the read buffer once a full reply has
      been read. The buffer is no longer truncated halfway through reading a
      reply. In addition: pass offset/length of protocol and content via the
      read tasks.
      77540aa3
  21. 21 Apr, 2011 2 commits