1. 10 Jul, 2018 3 commits
    • antirez's avatar
      Streams: make blocking for > a truly special case. · 1a02b5f6
      antirez authored
      To simplify the semantics of blocking for a group, this commit changes
      the implementation to better match the description we provide of
      conusmer groups: blocking for > will make the consumer waiting for new
      elements in the group. However blocking for any other ID will always
      serve the local history of the consumer.
      
      However it must be noted that the > ID is actually an alias for the
      special ID ms/seq of UINT64_MAX,UINT64_MAX.
      1a02b5f6
    • antirez's avatar
      Streams: send an error to consumers blocked on non-existing group. · a71e8148
      antirez authored
      To detect when the group (or the whole key) is destroyed to send an
      error to the consumers blocked in such group is a problem, so we leave
      the consumers listening, the sysadmin is free to create or destroy
      groups assuming she/he knows what to do. However a client may be blocked
      in a given consumer group, that is later destroyed. Then the stream
      receives new elements. In that case there is no sane behavior to serve
      the consumer... but to report an error about the group no longer
      existing.
      
      More about detecting this synchronously and why it is not done:
      
      1. Normally we don't do that, we leave clients blocked for other data
      types such as lists.
      
      2. When we free a stream object there is no longer information about
      what was the key it was associated with, so while destroying the
      consumer groups we miss the info to unblock the clients in that moment.
      
      3. Objects can be reclaimed in other threads where it is no longer safe
      to do client operations.
      a71e8148
    • antirez's avatar
      Streams: fix unblocking logic into a consumer group. · 09327f11
      antirez authored
      When a client blocks for a consumer group, we don't know the actual ID
      we want to be served: other clients blocked in the same consumer group
      may be served first, so the consumer group latest delivered ID changes.
      This was not handled correctly, all the clients in the consumer group
      were unblocked without data but the first.
      09327f11
  2. 09 Jul, 2018 6 commits
  3. 04 Jul, 2018 12 commits
  4. 03 Jul, 2018 4 commits
    • Jack Drogon's avatar
      Fix typo · 93238575
      Jack Drogon authored
      93238575
    • antirez's avatar
      Clarify the pending_querybuf field of clients. · 94b3ee61
      antirez authored
      94b3ee61
    • antirez's avatar
      Improve style of PR #5084. · 549b8b99
      antirez authored
      549b8b99
    • antirez's avatar
      Set repl_down_since to zero on state change. · 677d10b2
      antirez authored
      PR #5081 fixes an "interesting" bug about Redis Cluster failover but in
      general about the updating of repl_down_since, that is used in order to
      count the time a slave was left disconnected from its master.
      
      While the fix provided resolves the specific issue, in general the
      validity of repl_down_since is limited to states that are different
      than the state CONNECTED, and the disconnected time is set when the
      state is DISCONNECTED. However from CONNECTED to other states, the state
      machine must always go to DISCONNECTED first. So it makes sense to set
      the field to zero (since it is meaningless in that context) when the
      state is set to CONNECTED.
      677d10b2
  5. 02 Jul, 2018 1 commit
  6. 01 Jul, 2018 1 commit
  7. 30 Jun, 2018 1 commit
  8. 29 Jun, 2018 1 commit
  9. 28 Jun, 2018 10 commits
  10. 27 Jun, 2018 1 commit