- 04 Jul, 2016 2 commits
- 01 Jul, 2016 6 commits
- 30 Jun, 2016 1 commit
-
-
antirez authored
So far we used an external program (later executed within Redis) and parser in order to check RDB files for correctness. This forces, at each RDB format update, to have two copies of the same format implementation that are hard to keep in sync. Morover the former RDB checker only checked the very high-level format of the file, without actually trying to load things in memory. Certain corruptions can only be handled by really loading key-value pairs. This first commit attempts to unify the Redis RDB loadig code with the task of checking the RDB file for correctness. More work is needed but it looks like a sounding direction so far.
-
- 28 Jun, 2016 3 commits
- 27 Jun, 2016 2 commits
-
-
antirez authored
-
antirez authored
The quicklist takes a cached version of the ziplist representation size in bytes. The implementation must update this length every time the underlying ziplist changes. However quicklistReplaceAtIndex() failed to fix the length. During LSET calls, the size of the ziplist blob and the cached size inside the quicklist diverged. Later, when this size is used in an authoritative way, for example during nodes splitting in order to copy the nodes, we end with a duplicated node that may contain random garbage. This commit should fix issue #3343, however several problems were found reviewing the quicklist.c code in search of this bug that should be addressed soon or later. For example: 1. To take a cached ziplist length is fragile since failing to update it leads to this kind of issues. 2. The node splitting code needs auditing. For example it works just for a side effect of ziplistDeleteRange() to be able to cope with a wrong count of elem...
-
- 24 Jun, 2016 1 commit
-
-
Salvatore Sanfilippo authored
Fix RedisModule_Calloc() definition typo.
-
- 23 Jun, 2016 17 commits
-
-
Yossi Gottlieb authored
-
Salvatore Sanfilippo authored
Fix incorrect comment for checkForSentinelMode function
-
antirez authored
-
Salvatore Sanfilippo authored
added RM_Calloc implementation
-
antirez authored
-
antirez authored
I forgot -a when amending in the previous commit.
-
Salvatore Sanfilippo authored
Add RedisModule_CreateStringFromString().
-
antirez authored
Also avoid "static" in order to have symbols during crashes.
-
Salvatore Sanfilippo authored
Fix occasional RM_OpenKey() crashes.
-
Salvatore Sanfilippo authored
A string with 21 chars is not representable as a 64-bit integer.
-
tielei authored
-
Salvatore Sanfilippo authored
Use const in Redis Module API where possible.
-
antirez authored
This commit changes what provided by PR #3315 (merged) in order to let the user specify the log level as a string. The define could be also used, but when this happens, they must be decoupled from the defines in the Redis core, like in the other part of the Redis modules implementations, so that a switch statement (or a function) remaps between the two, otherwise we are no longer free to change the internal Redis defines.
-
Yossi Gottlieb authored
-
antirez authored
It's more natural to call the last entry added as "last", the original commet got me confused until I actually read the code.
-
antirez authored
Most of the time to check the last element is the way to go, however there are patterns where the contrary is the best choice. Zig-zag scanning implemented in this commmit always checks the obvious element first (the last added -- think at a loop where the last element allocated gets freed again and again), and continues checking one element in the head and one in the tail. Thanks to @dvisrky that fixed the original implementation of the function and proposed zig zag scanning.
-
Salvatore Sanfilippo authored
Optimized autoMemoryFreed loop
-
- 22 Jun, 2016 4 commits
-
-
Yossi Gottlieb authored
-
Dvir Volk authored
-
antirez authored
-
Yossi Gottlieb authored
-
- 21 Jun, 2016 1 commit
-
-
Yossi Gottlieb authored
-
- 20 Jun, 2016 1 commit
-
-
Yossi Gottlieb authored
-
- 17 Jun, 2016 1 commit
-
-
Salvatore Sanfilippo authored
fix: config set list-max-ziplist-size didn't support negative values
-
- 16 Jun, 2016 1 commit
-
-
Misha Nasledov authored
-