- 23 Jul, 2018 2 commits
- 20 Jul, 2018 2 commits
- 19 Jul, 2018 9 commits
-
-
antirez authored
They are actually delayed a few seconds, so let's call them "recent".
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
-
antirez authored
Related to #4727.
-
Salvatore Sanfilippo authored
move getClientsMaxBuffers func into info clients command
-
- 18 Jul, 2018 5 commits
-
-
antirez authored
-
antirez authored
See #5135 for more context.
-
antirez authored
See #5135 for some context.
-
Salvatore Sanfilippo authored
make active defrag test more stable
-
Oran Agra authored
on slower machines, the active defrag test tended to fail. although the fragmentation ratio was below the treshold, the defragger was still in the middle of a scan cycle. this commit changes: - the defragger uses the current fragmentation state, rather than the cache one that is updated by server cron every 100ms. this actually fixes a bug of starting one excess scan cycle - the test lets the defragger use more CPU cycles, in hope that the defrag will be faster, but also give it more time before we give up.
-
- 17 Jul, 2018 11 commits
-
-
Salvatore Sanfilippo authored
Accept write commands if persisting is disabled
-
Salvatore Sanfilippo authored
Update the comment
-
antirez authored
-
Salvatore Sanfilippo authored
Fix xreadgroup with '$' ID.
-
antirez authored
Related to #5135, see discussion there.
-
Salvatore Sanfilippo authored
fix rare replication stream corruption with disk-based replication
-
dejun.xdj authored
It's already checked if xreadgroup is set and groupname is NULL.
-
dejun.xdj authored
Redis will always return an empty result when '$' ID is specified with xreadgroup command, it's meaningless.
-
Oran Agra authored
The slave sends \n keepalive messages to the master while parsing the rdb, and later sends REPLCONF ACK once a second. rarely, the master recives both a linefeed char and a REPLCONF in the same read, \n*3\r\n$8\r\nREPLCONF\r\n... and it tries to trim two chars (\r\n) from the query buffer, trimming the '*' from *3\r\n$8\r\nREPLCONF\r\n... then the master tries to process a command starting with '3' and replies to the slave a bunch of -ERR and one +OK. although the slave silently ignores these (prints a log message), this corrupts the replication offset at the slave since the slave increases the replication offset, and the master did not. other than the fix in processInlineBuffer, i did several other improvments while hunting this very rare bug. - when redis replies with "unknown command" it includes a portion of the arguments, not just the command name. so it would be easier to understand what was recived, in my case, on the slave side, it was -ERR, but the "arguments" were the interesting part (containing info on the error). - about a year ago i added code in addReplyErrorLength to print the error to the log in case of a reply to master (since this string isn't actually trasmitted to the master), now changed that block to print a similar log message to indicate an error being sent from the master to the slave. note that the slave is marked as CLIENT_SLAVE only after PSYNC was received, so this will not cause any harm for REPLCONF, and will only indicate problems that are gonna corrupt the replication stream anyway. - two places were c->reply was emptied, and i wanted to reset sentlen this is a precaution (i did not actually see such a problem), since a non-zero sentlen will cause corruption to be transmitted on the socket.
-
antirez authored
-
Salvatore Sanfilippo authored
remove ineffective loop in dictGetSomeKeys.
-
- 16 Jul, 2018 11 commits
-
-
Salvatore Sanfilippo authored
Streams: using streamCompareID() instead of direct compare.
-
Salvatore Sanfilippo authored
bugfix in sdsReqType creating 64bit sds headers on 32bit systems
-
antirez authored
Reading the PR gave me the opportunity to better specify what the code was doing in places where I was not immediately sure about what was going on. Moreover I documented the structure in server.h so that people reading the header file will immediately understand what the structure is useful for.
-
Salvatore Sanfilippo authored
slave buffers were wasteful and incorrectly counted causing eviction
-
Salvatore Sanfilippo authored
Streams: correctly propagate xdel if needed
-
Oran Agra authored
A) slave buffers didn't count internal fragmentation and sds unused space, this caused them to induce eviction although we didn't mean for it. B) slave buffers were consuming about twice the memory of what they actually needed. - this was mainly due to sdsMakeRoomFor growing to twice as much as needed each time but networking.c not storing more than 16k (partially fixed recently in 237a38737). - besides it wasn't able to store half of the new string into one buffer and the other half into the next (so the above mentioned fix helped mainly for small items). - lastly, the sds buffers had up to 30% internal fragmentation that was wasted, consumed but not used. C) inefficient performance due to starting from a small string and reallocing many times. what i changed: - creating dedicated buffers for reply list, counting their size with zmalloc_size - when creating a new reply node from, preallocate it to at least 16k. - when appending a new reply to the buffer, first fill all the unused space of the previous node before starting a new one. other changes: - expose mem_not_counted_for_evict info field for the benefit of the test suite - add a test to make sure slave buffers are counted correctly and that they don't cause eviction
-
zhaozhao.zz authored
-
antirez authored
-
Salvatore Sanfilippo authored
Streams: free lp if all elements are deleted
-
antirez authored
Related to #5129.
-
Salvatore Sanfilippo authored
Streams: show last id for streams and groups
-