1. 19 Oct, 2018 1 commit
  2. 14 Sep, 2018 1 commit
  3. 12 Sep, 2018 1 commit
  4. 04 Jul, 2018 1 commit
  5. 25 May, 2018 2 commits
  6. 23 Apr, 2018 2 commits
  7. 10 Apr, 2018 1 commit
  8. 15 Mar, 2018 1 commit
  9. 22 Feb, 2018 1 commit
  10. 01 Dec, 2017 1 commit
  11. 10 Jul, 2017 1 commit
  12. 05 Jul, 2017 1 commit
  13. 03 Jul, 2017 1 commit
  14. 26 Jun, 2017 1 commit
  15. 10 May, 2017 1 commit
    • antirez's avatar
      Modules TSC: use atomic var for server.unixtime. · 1f598fc2
      antirez authored
      This avoids Helgrind complaining, but we are actually not using
      atomicGet() to get the unixtime value for now: too many places where it
      is used and given tha time_t is word-sized it should be safe in all the
      archs we support as it is.
      
      On the other hand, Helgrind, when Redis is compiled with "make helgrind"
      in order to force the __sync macros, will detect the write in
      updateCachedTime() as a read (because atomic functions are used) and
      will not complain about races.
      
      This commit also includes minor refactoring of mutex initializations and
      a "helgrind" target in the Makefile.
      1f598fc2
  16. 17 Apr, 2017 1 commit
  17. 27 Mar, 2017 1 commit
  18. 23 Feb, 2017 1 commit
  19. 20 Feb, 2017 2 commits
    • antirez's avatar
      84fa8230
    • antirez's avatar
      Use SipHash hash function to mitigate HashDos attempts. · adeed29a
      antirez authored
      This change attempts to switch to an hash function which mitigates
      the effects of the HashDoS attack (denial of service attack trying
      to force data structures to worst case behavior) while at the same time
      providing Redis with an hash function that does not expect the input
      data to be word aligned, a condition no longer true now that sds.c
      strings have a varialbe length header.
      
      Note that it is possible sometimes that even using an hash function
      for which collisions cannot be generated without knowing the seed,
      special implementation details or the exposure of the seed in an
      indirect way (for example the ability to add elements to a Set and
      check the return in which Redis returns them with SMEMBERS) may
      make the attacker's life simpler in the process of trying to guess
      the correct seed, however the next step would be to switch to a
      log(N) data structure when too many items in a single bucket are
      detected: this seems like an overkill in the case of Redis.
      
      SPEED REGRESION TESTS:
      
      In order to verify that switching from MurmurHash to SipHash had
      no impact on speed, a set of benchmarks involving fast insertion
      of 5 million of keys were performed.
      
      The result shows Redis with SipHash in high pipelining conditions
      to be about 4% slower compared to using the previous hash function.
      However this could partially be related to the fact that the current
      implementation does not attempt to hash whole words at a time but
      reads single bytes, in order to have an output which is endian-netural
      and at the same time working on systems where unaligned memory accesses
      are a problem.
      
      Further X86 specific optimizations should be tested, the function
      may easily get at the same level of MurMurHash2 if a few optimizations
      are performed.
      adeed29a
  20. 19 Feb, 2017 2 commits
  21. 30 Dec, 2016 1 commit
  22. 19 Sep, 2016 1 commit
  23. 07 Sep, 2016 1 commit
  24. 06 Jul, 2016 4 commits
  25. 14 Jun, 2016 1 commit
  26. 18 May, 2016 1 commit
    • antirez's avatar
      Fix modules compilation when libc malloc is used. · b09a6b6a
      antirez authored
      Compiling Redis worked as a side effect of jemalloc target specifying
      -ldl as needed linker options, otherwise it is not provided during
      linking and dlopen() API will remain unresolved symbols.
      b09a6b6a
  27. 10 May, 2016 1 commit
  28. 01 Oct, 2015 1 commit
  29. 26 Jul, 2015 1 commit
  30. 14 Jul, 2015 2 commits
  31. 23 Jun, 2015 1 commit
    • antirez's avatar
      Geo: big refactoring of geo.c, zset.[ch] removed. · 0b931390
      antirez authored
      This commit simplifies the implementation in a few ways:
      
      1. zsetScore implementation improved a bit and moved into t_zset.c where
         is now also used to implement the ZSCORE command.
      
      2. Range extraction from the sorted set remains a separated
         implementation from the one in t_zset.c, but was hyper-specialized in
         order to avoid accumulating results into a list and remove the ones
         outside the radius.
      
      3. A new type is introduced: geoArray, which can accumulate geoPoint
         structures in a vector with power of two expansion policy. This is
         useful since we have to call qsort() against it before returning the
         result to the user.
      
      4. As a result of 1, 2, 3, the two files zset.c and zset.h are now
         removed, including the function to merge two lists (now handled with
         functions that can add elements to existing geoArray arrays) and
         the machinery used in order to pass zset results.
      
      5. geoPoint structure simplified because of the general code structure
         simplification, so we no longer need to take references to objects.
      
      6. Not counting the JSON removal the refactoring removes 200 lines of
         code for the same functionalities, with a simpler to read
         implementation.
      
      7. GEORADIUS is now 2.5 times faster testing with 10k elements and a
         radius resulting in 124 elements returned. However this is mostly a
         side effect of the refactoring and simplification. More speed gains
         can be achieved by trying to optimize the code.
      0b931390
  32. 22 Jun, 2015 1 commit
    • antirez's avatar
      Geo: compile again with optimizations · 3d9031ed
      antirez authored
      For some reason the Geo PR included disabling the fact that Redis is
      compiled with optimizations. Apparently it was just @mattsta attempt to
      speedup the modify-compile-test iteration and there are no other
      reasons.
      3d9031ed